-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update smartapi.yaml #116
Update smartapi.yaml #116
Conversation
Updates for compatibility with TRAPI 1.4 edge sources specification
@GitHubbit I did a quick test and it seemed to work properly with BTE, which is great. Please leave it in this fork for now (we'll only merge this PR when we move all instances to TRAPI 1.4). We'll hopefully deploy a SmartAPI override file soon https://github.com/biothings/biothings_explorer/blob/trapi1-4-overrides/src/config/smartapi_overrides.json, which will allow the dev instance of BTE to use your fork's file and do TRAPI 1.4 source formatting properly for your KP. One note:
|
SmartAPI override file has been deployed. So BTE's dev instance should be showing the TRAPI 1.4 sources data correctly using the data in the BioThings API. Another note:
|
Believe this is addressed now: [https://github.com/biothings/biothings_explorer/issues/617#issuecomment-1562026459](Multiomics ClinicalTrials KP: NEEDED SmartAPI yaml edits) TRAPI 1.3 only |
I've looked at these edits, but I haven't tested them myself. I agree that they should fix the x-bte annotation issues for the registered yaml, which BTE's prod instance uses and is for TRAPI 1.3 support. The next steps are:
And after that is testing!
|
The registered yaml should now be working and "TRAPI 1.4", after this PR merge and 59c6a56. The override yaml in the fork is working but probably isn't "TRAPI 1.4" because the source.edge_sources info is missing. |
Updates to smartapi.yaml for Multiomics Clinical Trials KP for compatibility with TRAPI 1.4 edge sources specification
@colleenXu