myndla-api: Support feide users without organization #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnatten
force-pushed
the
missing-feide-organization
branch
from
3ab8b59 to
ff679bc
Compare
Previously we returned an error if a user without organization attempted to login. This patch allows no-organization users to still log in.
jnatten
force-pushed
the
missing-feide-organization
branch
from
ff679bc to
9108807
Compare
gunnarvelle
reviewed
Nov 6, 2024
| .getOrElse(user.organization.getOrElse { | ||
| // TODO: Maybe this needs to be optional instead? | ||
| logger.warn(s"User ${user.id} has no stored organization") | ||
| "Unknown" |
There was a problem hiding this comment.
Siden dette vises fram på profilsida er det nesten bedre å defaulte til tom streng.
|
Sikt rapporterer at dei har funne en feil hos seg, så dette kan vi legge på is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ser vi kaster en del feil i prod-miljøet fordi noen brukere ikke har noen organizations.
Antar at vi kan bare droppe å bry oss om det 😄
Krever en liten endring i graphql-api som kommer i morgen