Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force all Campaign Block images to be 200x200 #2123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jonas-C
Copy link
Contributor

@Jonas-C Jonas-C commented Feb 12, 2024

@Jonas-C Jonas-C requested a review from a team February 12, 2024 10:51
Copy link
Contributor

@rauboti rauboti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser ut til å fungere greit på bilder som er kvadratiske eller nesten kvadratiske. Men kan bli rotete for bilder med andre aspect ratios.
image
Er det ev. et alternativ å bruke canvas og drawImage til å croppe bildene? Blir jo en litt større operasjon, men kanskje visuelt penere. Med mindre dette er et så søkt eksempel at det aldri vil skje, in which case, kindly ignore 💯

@John-H-Christiansen
Copy link
Collaborator

Kunne du ha byttet ut :
max-width: 200px;
/* This is unset globally on images */
max-height: 200px !important;
min-width: 200px;
min-height: 200px;

Med:
aspect-ratio: 1;
max-block-size: 200px;
min-block-size: 200px;
?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants