Query on old contextids #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fungerte overraskende bra. Testa lokalt å fjerne en plassering for en artikkel og dermed en kontekst og fikk denne sida: |
jnatten
reviewed
Dec 4, 2024
Comment on lines
+1595
to
+1596
| SELECT json_agg(obj->>'contextId') | ||
| FROM jsonb_array_elements(contexts) AS obj |
There was a problem hiding this comment.
Vet ikke om jeg forstår koden helt ennå så ikke skyt meg om dette er dumt 😄
Dette betyr at vi henter contextids fra en annen kolonne på samme rad sant?
Hvorfor kan vi ikke bare bruke node.getContexts().map(ctx -> ctx.getId()) eller laget en helper på node for å gjøre det? Vil vel ikke koste stort mer ytelse og da slipper vi å holde dataen i sync?
There was a problem hiding this comment.
Heile poenget er at vi må ha en liste med kontekstider som ikkje lenger er i lista med kontekster. For at vi skal kunne hente noder basert på gamle kontekster, som den nye testmetoden viser.
jnatten
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legger til liste med alle gamle contextids for en node.