Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github action versions #95

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

svrdlans
Copy link
Contributor

connects https://github.com/NFIBrokerage/support/issues/80

Created locally by script: handles Node.js 16 deprecation warnings by using new action versions

@svrdlans svrdlans self-assigned this Mar 15, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build be6e472b87d8062c24352b4bef8c1f0f3f12b4e2-PR-95

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 4ddf4ea20768d1a7ac279a72ed5d302d58ce7803: 0.0%
Covered Lines: 709
Relevant Lines: 709

💛 - Coveralls

@svrdlans
Copy link
Contributor Author

@the-mikedavis I see some tests failing, I believe unrelated to the PR (github action version bumps), suspecting they are related to ES 22.6.0

@the-mikedavis the-mikedavis merged commit bbbd803 into main Mar 18, 2024
8 of 12 checks passed
@the-mikedavis the-mikedavis deleted the bump-github-action-versions branch March 18, 2024 21:54
@the-mikedavis
Copy link
Collaborator

the-mikedavis commented Mar 18, 2024

Yeah I think I just need to revert 4ddf4ea - I believe it makes the older eventstore versions error out on startup because they don't recognize the option. (Same as a0d5001)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants