From 7948d0ba8c0877fc85cf0cac2ab3b5120ece4bc4 Mon Sep 17 00:00:00 2001 From: Rolf Kristensen Date: Wed, 6 Dec 2023 20:30:19 +0100 Subject: [PATCH] Improve XML docs for AddNLog and UseNLog (#710) --- .../Extensions/ConfigureExtensions.cs | 6 ++---- .../Extensions/ConfigureExtensions.cs | 12 ++++++------ .../NLog.Extensions.Logging.csproj | 2 +- 3 files changed, 9 insertions(+), 11 deletions(-) diff --git a/src/NLog.Extensions.Hosting/Extensions/ConfigureExtensions.cs b/src/NLog.Extensions.Hosting/Extensions/ConfigureExtensions.cs index 9d11f4ba..784f18bd 100644 --- a/src/NLog.Extensions.Hosting/Extensions/ConfigureExtensions.cs +++ b/src/NLog.Extensions.Hosting/Extensions/ConfigureExtensions.cs @@ -17,8 +17,7 @@ namespace NLog.Extensions.Hosting public static class ConfigureExtensions { /// - /// Enable and configure NLog as a logging provider for buildable generic host (.NET Core 2.1+). - /// Can be used in discrete containers as well. + /// Enable NLog as logging provider for Microsoft Extension Logging /// /// /// IHostBuilder for chaining @@ -29,8 +28,7 @@ public static IHostBuilder UseNLog(this IHostBuilder builder) } /// - /// Enable and configure NLog as a logging provider for buildable generic host (.NET Core 2.1+). - /// Can be used in discrete containers as well. + /// Enable NLog as logging provider for Microsoft Extension Logging /// /// /// NLogProviderOptions object to configure NLog behavior diff --git a/src/NLog.Extensions.Logging/Extensions/ConfigureExtensions.cs b/src/NLog.Extensions.Logging/Extensions/ConfigureExtensions.cs index bc1d499e..680e055c 100644 --- a/src/NLog.Extensions.Logging/Extensions/ConfigureExtensions.cs +++ b/src/NLog.Extensions.Logging/Extensions/ConfigureExtensions.cs @@ -113,10 +113,10 @@ public static ILoggingBuilder AddNLog(this ILoggingBuilder builder, NLogProvider } /// - /// Enable NLog as logging provider for Microsoft Extension Logging + /// Enable NLog as logging provider for Microsoft Extension Logging, and loads the new NLog . /// /// - /// New NLog config. + /// New NLog config to be loaded. /// ILoggingBuilder for chaining public static ILoggingBuilder AddNLog(this ILoggingBuilder builder, LoggingConfiguration configuration) { @@ -124,10 +124,10 @@ public static ILoggingBuilder AddNLog(this ILoggingBuilder builder, LoggingConfi } /// - /// Enable NLog as logging provider for Microsoft Extension Logging + /// Enable NLog as logging provider for Microsoft Extension Logging, and loads the new NLog . /// /// - /// New NLog config. + /// New NLog config to be loaded. /// NLog Logging Provider options /// ILoggingBuilder for chaining public static ILoggingBuilder AddNLog(this ILoggingBuilder builder, LoggingConfiguration configuration, NLogProviderOptions options) @@ -145,10 +145,10 @@ public static ILoggingBuilder AddNLog(this ILoggingBuilder builder, LoggingConfi } /// - /// Enable NLog as logging provider for Microsoft Extension Logging + /// Enable NLog as logging provider for Microsoft Extension Logging, and loads NLog config from /// /// - /// relative path to NLog configuration file. + /// relative file-path to NLog configuration file. /// ILoggingBuilder for chaining public static ILoggingBuilder AddNLog(this ILoggingBuilder builder, string configFileRelativePath) { diff --git a/src/NLog.Extensions.Logging/NLog.Extensions.Logging.csproj b/src/NLog.Extensions.Logging/NLog.Extensions.Logging.csproj index 8aafaf5d..cebbf08f 100644 --- a/src/NLog.Extensions.Logging/NLog.Extensions.Logging.csproj +++ b/src/NLog.Extensions.Logging/NLog.Extensions.Logging.csproj @@ -81,7 +81,7 @@ List of major changes in NLog 5.0: https://nlog-project.org/2021/08/25/nlog-5-0- - +