Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor esmFldsExchange_nems #63

Closed
DeniseWorthen opened this issue Apr 4, 2022 · 0 comments · Fixed by ESCOMP/CMEPS#279
Closed

Refactor esmFldsExchange_nems #63

DeniseWorthen opened this issue Apr 4, 2022 · 0 comments · Fixed by ESCOMP/CMEPS#279
Assignees
@DeniseWorthen

Comments

@DeniseWorthen
Copy link
Collaborator

The CMEPS routine which defines the field exchanges for NEMS does not have the same structure as the routines used for HAFS and CESM. Specifically, in those cases the routine is called separately for the advertise and initialize phases. The NEMS routine should be refactored to be consistent with how CESM or HAFS coupling is implemented.
@DeniseWorthen DeniseWorthen mentioned this issue Apr 4, 2022
Merged
5 tasks
DeniseWorthen added a commit to DeniseWorthen/CMEPS that referenced this issue Apr 23, 2022
@DeniseWorthen
Refactor nems field exchange; set default masks for mapping in med_in…
ef360ea 
…ternalstate (ESCOMP#279)

Refactors esmFldsExchange_nems.F90 to use separate advertise and initialize phases and to check that a component is present before advertising a field to or from that component. Implements default src and dst mask values in place of the code currently in med_map_mod.F90. Fixes NOAA-EMC#63 and NOAA-EMC#64.
This was referenced Apr 25, 2022
Merged
Merged
@DeniseWorthen DeniseWorthen self-assigned this Apr 27, 2022
junwang-noaa pushed a commit that referenced this issue Jun 9, 2022
@uturuncoglu @climbfuji
@fvitt @jedwards4b @mvertens @DeniseWorthen
Update CMEPS to its ESCOMP/master branch 20220607 commit (#67)
424a086 
* add new flux computation for UFS model and add new coupling mode for exchange grid implementation
* fix area field for new flux algorithm
* send fluxes to atmospheric model
* initial implementation for sending fluxes to UFS ATM
* update CCPP host model
* fix latent and sensible heat fluxes and clean code
* add new coupling mode for side by side flux comparison
* fix CCPP host model for latent and sensible heat fluxes
* fix aoflux calculation on agrid and add missing error checks
* add option to write meshes and update code that retrieve area information from xgrid
* update ccpp host based on recent changes in ccpp framework
* fix for providing cell area to CCPP host model
* make ccpp physics options configurable
* Refactor nems field exchange; set default masks for mapping in med_internalstate (ESCOMP#279)
Refactors esmFldsExchange_nems.F90 to use separate advertise and initialize phases and to check that a component is present before advertising a field to or from that component. Implements default src and dst mask values in place of the code currently in med_map_mod.F90. Fixes #63 and #64.
* use mesh file instead of grid name (ESCOMP#285)
This was done so that vertical component used in grid name does not affect tests.

Co-authored-by: Dom Heinzeller <climbfuji@ymail.com>
Co-authored-by: Francis Vitt <fvitt@ucar.edu>
Co-authored-by: Courtney Peverley <courtneyp@izumi.cgd.ucar.edu>
Co-authored-by: Jim Edwards <jedwards@ucar.edu>
Co-authored-by: mvertens <mvertens@users.noreply.github.com>
Co-authored-by: Denise Worthen <denise.worthen@noaa.gov>
Co-authored-by: Mariana Vertenstein <mvertens@ucar.edu>
Co-authored-by: Ufuk Turuncoglu <ufuk.turuncoglu@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DeniseWorthen DeniseWorthen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor nems field exchange; set default masks for mapping in med_internalstate DeniseWorthen/CMEPS
1 participant
@DeniseWorthen