Update CMEPS #60
Merged
Update CMEPS #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change all shebangs to explicitly use python3
fix unitialized variable in timeInit, remove option ifdays0
Add license file.
The code to parse this value will live in a different repository (in the share code), so it would be annoying to have the valid values here: if a new valid value is added, changes would be needed here in addition to the share code.
…re/hafs_couplehycom_cdeps
…re/history_updates
…re/hafs_coupleww3
…shr_flux_adjust_constants
cmeps directory refactor ### Description of changes CMEPS directory refactor ### Specific notes The following directory changes were made: - util/ => ufs/ - nuopc_cap_share => cesm/nuopc_cap_share/ - share/src/shr_flux_mod => cesm/flux_atmocn/shr_flux_mod (cesm only) - share/cmeps/* => cesm/nuopc_cap_share (cesm only) Also shr_constants_mod.F90 is now only used by cesm and the the file util/shr_const_mod.F90 has been moved and renamed to ufs/ufs_constants_mod.F90 In addition med_aofluxes_mod.F90 now has separate calls to the ufs and cesm atmocn flux computation. Contributors other than yourself, if any: CMEPS Issues Fixed: None Are changes expected to change answers? bit-for-bit Any User Interface Changes (namelist or namelist defaults changes)? No Testing performed: CESM testing: verified that the following tests are bfb with cesm2_3_alpha07a on cheyenne : IRT_Ld7.f09_g17.BHIST.cheyenne_intel.allactive-defaultio ERS_Ld3.f45_g37_rx1.A.cheyenne_intel UFS testing: ufs-weather-model [0cf60348](https://github.com/ufs-community/ufs-weather-model) using CMEPS e703499
Allows the inst and avg history files for the ATM to be written on the cubed sphere tiles instead of the mesh by setting the configuration variable `` history_tile_atm`` = ``cubed sphere tile size`` (e.g. 96,192,384). CMEPS Issues Fixed (include github issue #): NOAA-EMC/CMEPS [NOAA-EMC#59](NOAA-EMC#59) Are changes expected to change answers? bit for bit Any User Interface Changes (namelist or namelist defaults changes)? No. History files for the ATM will be written on the mesh unless tiled history is requested via namelist configuration. Testing performed if application target is CESM: - Verified that ERS_Ld7.f19_g17.B1850.cheyenne_intel.allactive-defaultio was bfb with cesm2_3_alpha07b Testing performed if application target is UFS-coupled: - Tested ufs-weather-model develop branch against a CMEPS feature branch containing these changes. Both inst and avg history files were written for atm, ice and ocn. The files for ice and ocn were compared directly using cprnc and all were B4B. For the atm history files, the history files containing the mesh were post-processed with NCL to write the fields on the individual tiles. Multiple fields at multiple timesteps were checked against the tiled history file output and all were identical. Hashes used for testing: CESM: - repository to check out: https://github.com/ESCOMP/CESM.git - hash: cesm2_3_alpha07b (updates of cmeps to this branch and share to main) UFS-coupled, then umbrella repostiory to check out and associated hash: - repository to check out: https://github.com/DeniseWorthen/ufs-weather-model - branch: feature/updcmeps - hash: b00bf69
16 tasks
| ntiles = ng/(lnx*lny) | ||
| write(tmpstr,*) subname, 'ng,lnx,lny,ntiles = ',ng,lnx,lny,ntiles | ||
| call ESMF_LogWrite(trim(tmpstr), ESMF_LOGMSG_INFO) | ||
| if (ntiles /= 6) then |
There was a problem hiding this comment.
So at this time, we can only write global fv3 files on tiles, not regional fv3 which has one tile?
There was a problem hiding this comment.
Yes, that is right. I did not attempt to make the CMEPS change for anything other than global. Other than HAFS I don't know of another application which uses both FV3atm and CMEPS and I wasn't sure enough about the various configurations HAFS runs.
junwang-noaa
approved these changes
Nov 30, 2021
MinsukJi-NOAA
approved these changes
Nov 30, 2021
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nemssubdirectory (containing utility functions, including the aoflux module) with subdirectoryufsand removes unused modules-fixes #59