Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CMEPS; refactor esmFieldsExchange_nems and default_masks #65

Merged
merged 30 commits into from
May 2, 2022
Merged

Update CMEPS; refactor esmFieldsExchange_nems and default_masks #65

merged 30 commits into from
May 2, 2022

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Apr 25, 2022 •
edited
Loading

Fixes Issue #64
Fixes Issue #63

  • Refactors the setting of the source and destination masking by specifying two (src,dst) default masks for each component. This cleans up and simplifies the setting of the masking maps.
  • Refactors esmFieldsExchange to be consistent with the advertise and initialize phases used by CESM and HAFS configurations.
  • Implements a check that each component pair for a field advertise is present. For example, for a field frAtm and toOcn, a check is implemented at the advertise phase that both an ATM and OCN components are present.
  • Permits coupling of ATM-WAV with the CMEPS mediator.

DeniseWorthen and others added 30 commits September 7, 2021 17:46
@DeniseWorthen
add fix for file writing when dststatus_print=true
233a89b 
* add local flag to control whether to write the dststatus file
for a particular RH. This prevents writing a dststatus file for
consf_aofrac which contains garbage (since the RH is a copy, and
dststatus field is not set) or a dststatus file for mapcopy
@DeniseWorthen
Merge remote-tracking branch 'escomp/master' into feature/updcmeps
c26a1b6
@DeniseWorthen
Merge remote-tracking branch 'escomp/master' into feature/updcmeps
aae1fe9
@DeniseWorthen
Merge remote-tracking branch 'MV/feature/cism_bugfixes' into feature/…
a0011cb 
…updcmeps
@DeniseWorthen
Merge branch 'NOAA-EMC:emc/develop' into feature/updcmeps
88c9808
@DeniseWorthen
Merge remote-tracking branch 'escomp/master' into feature/updcmeps
391ebab
@fvitt
Include Sl_soilw field exchange for CAM CARMA aerosol configurations (E…
0c9b470 
…SCOMP#268)

New field exchanges needed for CESM/CAM CARMA
@uturuncoglu
fix aoflux calculation on agrid and add missing error checks
4f93182
initialize count
c719817
@uturuncoglu
Merge pull request ESCOMP#271 from uturuncoglu/hotfix/aoflux_agrid
a75898f 
fix aoflux calculation on agrid and add missing error checks
@jedwards4b
Merge pull request ESCOMP#273 from peverwhee/nuopc_tests
82ee2f3 
Description of changes

initialize drydep_nflds to 0 in seq_drydep_readnl.

Issue found when running CAM test ERP_Ln9_Vnuopc.ne5pg3_ne5pg3_mg37.QPC6.izumi_nag.cam-outfrq9s_clubbmf with the nuopc driver. Got the following error (and preceding log message):

    [0] (seq_drydep_init) Number of dry deposition fields transfered is **
    ================================================================================
    = BAD TERMINATION OF ONE OF YOUR APPLICATION PROCESSES
    = PID 117892 RUNNING AT i042.cgd.ucar.edu
    = EXIT CODE: 9
    = CLEANING UP REMAINING PROCESSES
    = YOU CAN IGNORE THE BELOW CLEANUP MESSAGES

Specific notes

Contributors other than yourself, if any: N/A

CMEPS Issues Fixed (include github issue #): resolves ESCOMP#272

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial) No answer changes.

Any User Interface Changes (namelist or namelist defaults changes)? no user interface changes
Testing performed

Testing performed if application target is CESM:

(recommended) CIME_DRIVER=nuopc scripts_regression_tests.py

    machines:
    details (e.g. failed tests):

(recommended) CESM testlist_drv.xml

    machines and compilers:
    details (e.g. failed tests):

(optional) CESM prealpha test

    machines and compilers
    details (e.g. failed tests):

    (other) please described in detail
        machines and compilers: izumi CAM aux_cam test ERP_Ln9_Vnuopc.ne5pg3_ne5pg3_mg37.QPC6.izumi_nag.cam-outfrq9s_clubbmf with nuopc_driver
        details (e.g. failed tests): No failures.

Testing performed if application target is UFS-coupled:

    (recommended) UFS-coupled testing
        description:
        details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

    (recommended) UFS-HAFS testing
        description:
        details (e.g. failed tests):

Hashes used for testing:

CESM:

    repository to check out: ESCOMP/CESM.git
    branch/hash:

UFS-coupled, then umbrella repostiory to check out and associated hash:

    repository to check out:
    branch/hash:

UFS-HAFS, then umbrella repostiory to check out and associated hash:

    repository to check out:
    branch/hash:
@jedwards4b
clean version of add_container_support (ESCOMP#276)
abce725
@mvertens
Addition of enthalpy fluxes in CESM (ESCOMP#278)
a332fc8 
Add ability to send enthalpy fluxes back to MOM6 and at the same time adding a correction term to the sensible heat flux sent back to CAM.
@DeniseWorthen
Merge branch 'NOAA-EMC:emc/develop' into feature/updcmeps
052c404
@jedwards4b
correct COMP_NAME (was CIME_COMP)
f6c8f0b
@jedwards4b
Merge pull request ESCOMP#280 from jedwards4b/buildexe_fix
20af1d7 
Description of changes

Correct replacement of MODEL with COMP_NAME in buildexe.
Specific notes

Fixes ESCOMP#281
Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)

Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed

Testing performed if application target is CESM:

(recommended) CIME_DRIVER=nuopc scripts_regression_tests.py

    machines: cheyenne
    details (e.g. failed tests):

(recommended) CESM testlist_drv.xml

    machines and compilers:
    details (e.g. failed tests):

(optional) CESM prealpha test

    machines and compilers
    details (e.g. failed tests):

    (other) please described in detail
        machines and compilers
        details (e.g. failed tests): Build case SMS_D.f09_t061.B1850MOM.cheyenne_intel

Testing performed if application target is UFS-coupled:

    (recommended) UFS-coupled testing
        description:
        details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

    (recommended) UFS-HAFS testing
        description:
        details (e.g. failed tests):

Hashes used for testing:

CESM:

    repository to check out: ESCOMP/CESM.git
    branch/hash:

UFS-coupled, then umbrella repostiory to check out and associated hash:

    repository to check out:
    branch/hash:

UFS-HAFS, then umbrella repostiory to check out and associated hash:

    repository to check out:
    branch/hash:
@jedwards4b
move pio parameters to nuopc.runconfig input file
27dd3d0
@jedwards4b
X case compiles
a21f70b
@jedwards4b
ongoing work
a3e3f87
@jedwards4b
more read config
aab10fc
@jedwards4b
get logging to work
8f4737d
@jedwards4b
some cleanup
25d0e73
@jedwards4b
must work with ufs
1193194
@jedwards4b
more logging fixes, correct syntax in shr_pio_mod
aff27cb
@jedwards4b
clean up code
d23ad4b
@jedwards4b
fix bugs in pio interface
d8e82e8
@jedwards4b
handle inst number in fortran
167b0eb
@jedwards4b
Merge pull request ESCOMP#275 from jedwards4b/modelio_to_runconfig
fb16730 
### Description of changes
Update shr_pio_mod, removing mct centric initialization.
Improve logging and make sure logs go to the correct component.
Depends on cime branch async_io_in_esmf

### Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers? bfb

Any User Interface Changes (namelist or namelist defaults changes)?
The modelio namelist has been eliminated and the parameters from that file were moved to nuopc.runconfig,
The xml variable PIO_ASYNC_INTERFACE was changed from a global variable to one that could be set individually
for each component. 


### Testing performed

Testing performed if application target is CESM:
- [X] (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py
   - machines: cheyenne intel 
   - details (e.g. failed tests): IRT_N2_Vmct_Ln9.f19_g16_rx1.A.cheyenne_intel fails, apparently expected.

- [ ] (recommended) CESM testlist_drv.xml
   - machines and compilers:
   - details (e.g. failed tests):
- [x] (optional) CESM prealpha test
   - machines and compilers
   - details (e.g. failed tests):
- [ ] (other) please described in detail
   - machines and compilers
   - details (e.g. failed tests):

Testing performed if application target is UFS-coupled:
- [ ] (recommended) UFS-coupled testing
   - description:
   - details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:
- [ ] (recommended) UFS-HAFS testing
   - description:
   - details (e.g. failed tests):

### Hashes used for testing:

- [ ] CESM:
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch/hash:
- [ ] UFS-coupled, then umbrella repostiory to check out and associated hash:
  - repository to check out:
  - branch/hash:
- [ ] UFS-HAFS, then umbrella repostiory to check out and associated hash:
  - repository to check out:
  - branch/hash:
@DeniseWorthen
Refactor nems field exchange; set default masks for mapping in med_in…
ef360ea 
…ternalstate (ESCOMP#279)

Refactors esmFldsExchange_nems.F90 to use separate advertise and initialize phases and to check that a component is present before advertising a field to or from that component. Implements default src and dst mask values in place of the code currently in med_map_mod.F90. Fixes NOAA-EMC#63 and NOAA-EMC#64.
@DeniseWorthen
Merge remote-tracking branch 'escomp/master' into feature/updcmeps
70d3f16
@DeniseWorthen DeniseWorthen mentioned this pull request Apr 25, 2022
Merged
16 tasks
@DeniseWorthen DeniseWorthen marked this pull request as ready for review April 25, 2022 12:27
@DeniseWorthen DeniseWorthen requested review from binli2337 and removed request for binli2337 April 27, 2022 10:05
@DeniseWorthen DeniseWorthen self-assigned this Apr 27, 2022
@DeniseWorthen DeniseWorthen merged commit 763405c into NOAA-EMC:emc/develop May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junwang-noaa junwang-noaa junwang-noaa approved these changes

@binli2337 binli2337 binli2337 approved these changes

Assignees

@DeniseWorthen DeniseWorthen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@DeniseWorthen @binli2337 @junwang-noaa @fvitt @uturuncoglu @jedwards4b @mvertens