Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting GSI and Fortran standard issues in GSI master #13

Closed
MichaelLueken opened this issue Jun 12, 2020 · 2 comments
Closed

Correcting GSI and Fortran standard issues in GSI master #13

MichaelLueken opened this issue Jun 12, 2020 · 2 comments
Assignees
@MichaelLueken

Comments

@MichaelLueken
Copy link
Contributor

There are several coding standard issues with the routines in the GSI. Have been going through and correcting these issues within the code. Thus far, issues corrected have included:

  • Ensuring proper indentation in all routines.
  • Ensuring proper precision is given for all real values.
  • Ensuring that integers are given (i_kind) at variable declaration.
  • Several routines are full of random capitalization. Ensure that variables, if, do, while, and other intrinsic functions are lower case through out.
  • Replacing .ge., .le., .gt., .lt., and .eq. with >=, <=, >, <, and ==.
  • Replacing .F90 with .f90 for routines that don't contain machine logic.

This work was started in the ProdGSI repo, but was ported to NOAA-EMC/GSI. Have cleared through:

src/gsi/gsi_4dcouplermod.f90

This work can be found in:

https://github.com/MichaelLueken-NOAA/GSI/commits/feature/code_cleanup_2020
@MichaelLueken MichaelLueken self-assigned this Jun 12, 2020
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Jun 12, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13.
e997366 
feature/code_cleanup_2020: Begin addressing GSI and Fortran coding standard issues in ProdGSI/master.  Cleared through:
* src/gsi/hybrid_ensemble_parameters.f90

None of the modifications from this update affect results.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Jun 15, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13.
766e4e1 
Merge branch 'master' into feature/code_cleanup_2020
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Jun 19, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
81acc83 
… issues in the master. Finished through src/gsi/intlwcp.f90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Jun 19, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Merged master at d74bc03 to feature/code_cl…
399a170 
…eanup_2020 branch.
@MichaelLueken
Copy link
Contributor Author

From 06/15 - 06-19, cleared through src/gsi/intlwcp.f90. Updated feature/code_cleanup_2020 branch with the latest updates from the master.

MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Jun 23, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
2b3a26a 
… issues in the master. Finished through src/gsi/intrw.f90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Jun 26, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
182236c 
… issues in the master. Finished through src/gsi/lagmod.f90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Jul 2, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
4b18793 
… issues in the master. Finished through src/gsi/m_cldchnode.F90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Jul 10, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
e9aa185 
… issues in the master. Finished through src/gsi/m_find.f90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Jul 17, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
af72a84 
… issues in the master. Finished through src/gsi/m_o3lnode.F90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Jul 24, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
a2ceea6 
… issues in the master. Finished through src/gsi/mod_strong.f90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Jul 29, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
41f72e1 
… issues in the master. Finished through src/gsi/m_pblhnode.F90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Jul 29, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Merge branch 'master' into feature/code_cle…
ef76092 
…anup_2020
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Jul 31, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
3c888b4 
… issues in the master. Finished through src/gsi/m_pcpnode.F90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Aug 7, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
9741cab 
… issues in the master. Finished through src/gsi/m_rerank.f90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Aug 14, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
0b01a67 
… issues in the master. Finished through src/gsi/m_rwnode.F90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Aug 14, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
856d5f8 
… issues in the master. Finished through src/gsi/m_sstnode.F90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Aug 19, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
e65cf4a 
… issues in the master. Finished through src/gsi/m_stubtimer.f90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Aug 20, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
093682e 
… issues in the master. Finished through src/gsi/m_swcpnode.F90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Aug 21, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
9063dd0 
… issues in the master. Finished through src/gsi/m_tcamtnode.F90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Aug 28, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
004a191 
… issues in the master. Finished through src/gsi/ncepgfs_ghg.f90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Sep 3, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
e72c035 
… issues in the master. Finished through src/gsi/ncepnems_io.f90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Sep 3, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Merge branch 'master' into feature/code_cle…
6b2d0ca 
…anup_2020
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Sep 4, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
fb2fe8d 
… issues in the master. Finished through src/gsi/netcdfgfs_io.f90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Sep 9, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
821b0f6 
… issues in the master. Finished through src/gsi/nlmsas_ad.f90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Sep 25, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
f7034c7 
… issues in the master. Finished through src/gsi/normal_rh_to_q.f90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Oct 5, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
18548fd 
… issues in the master. Finished through src/gsi/observer.F90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Oct 19, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
1e4f0c9 
… issues in the master. Finished through src/gsi/obsmod.F90.
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Oct 23, 2020
@MichaelLueken
GitHub Issue NOAA-EMC#13. Continuing to clear through coding standard…
f0ba91a 
… issues in the master. Finished through src/gsi/pcgsqrt.f90.
@ScottSieron-NOAA ScottSieron-NOAA mentioned this issue Dec 15, 2021
Closed
@XuLi-NOAA XuLi-NOAA mentioned this issue Feb 28, 2022
Closed
lbi2018 pushed a commit to lbi2018/GSI that referenced this issue Mar 4, 2022
@BinLiu-NOAA
Bug fix for enkf analysis steps when using t(tv) as a control vector …
af7b978 
…variable for regional FV3 DA (NOAA-EMC#12)

*Bug fix for EnKF analysis steps when using t (tv) as a control vector variable for regional FV3 DA.
*Whitespace and indentation clean-ups were made in src/enkf/gridio_fv3reg.f90.
Notes:
This PR addresses issue NOAA-EMC#13, which was reported by Jonathan Poterjoy (UMD).
And this bug should have affected all the EnKF steps (mean, update, recenter, etc.)
The bug fix is based on the diagnoses and discussions among @BinLiu-NOAA and @TingLei-NOAA (EMC), @XL-OU, Jonathan Poterjoy (UMD), Jason Sippel (HRD), etc.
@ilianagenkova ilianagenkova mentioned this issue Mar 14, 2022
Merged
@MichaelLueken
Copy link
Contributor Author

Closing obsolete issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelLueken MichaelLueken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MichaelLueken