Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fixes for regional EnKF, GNU compilers; change build.comgsi; move gsdcloud to src/ #17

Closed
guoqing-noaa opened this issue Jun 15, 2020 · 0 comments · Fixed by #18
Closed

bug fixes for regional EnKF, GNU compilers; change build.comgsi; move gsdcloud to src/ #17

guoqing-noaa opened this issue Jun 15, 2020 · 0 comments · Fixed by #18

Comments

@guoqing-noaa
Copy link
Contributor

  1. added FV3GFS_NCIO_Fortran_FLAGS for GNU compilers

  2. Moved gsdcloud to src/, make appropriate changes in CMakeLists.txt and a few bug fixes

  3. pietc.f90 and pvqc_tables.f90

    use kinds, only: dp,dpc
--> use kinds, only: r_kind, dp, dpc

This change is to avoid compiling error

error #6580: Name in only-list does not exist or is not accessible. [DP]

Don't know the exact reason, but either (1) removing all #ifdef block in kinds.F90 or (2) use r_kind first can solve this problem.

  1. updated util/EnKF/arw/src/enspreproc_regional.fd/CMakeLists.txt

  2. bug fixes for GNU compilers and regional EnKF.

  3. updated ush/build.comgsi for community users
@MichaelLueken MichaelLueken linked a pull request Jun 15, 2020 that will close this issue
GitHub Issue NOAA-EMC/GSI#17. Bug fixes for regional EnKF, GNU compilers; change build.comgsi; move gsdcloud to src. #18
Merged
MichaelLueken added a commit that referenced this issue Jun 17, 2020
@MichaelLueken
Merge pull request #18 from comgsi/comGSI-2020002
fcec2a9 
GitHub Issue #17.  Bug fixes for regional EnKF, GNU compilers; change build.comgsi; move gsdcloud to src.
@jderber-NOAA jderber-NOAA mentioned this issue Mar 13, 2021
Closed
@ScottSieron-NOAA ScottSieron-NOAA mentioned this issue Dec 15, 2021
Closed
@XuLi-NOAA XuLi-NOAA mentioned this issue Feb 28, 2022
Closed
@ilianagenkova ilianagenkova mentioned this issue Mar 14, 2022
Merged
hu5970 referenced this issue in hu5970/GSI Jun 29, 2022
@hu5970
Merge pull request #17 from hu5970/baseE
c4f07cf 
remove subdmodule fix
aerorahul pushed a commit to NOAA-EMC/GSI-utils that referenced this issue Jun 30, 2022
@MichaelLueken
Merge pull request #18 from comgsi/comGSI-2020002
6634c17 
GitHub Issue NOAA-EMC/GSI#17.  Bug fixes for regional EnKF, GNU compilers; change build.comgsi; move gsdcloud to src.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@guoqing-noaa