fix a bug in EnKF that can cause segfault in a diagnostic print #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RussTreadon-NOAA - this should probably get included in the GFS v16 branch since this bug could lead to a crash. |
|
Hi Jeff, Since this is only a single commit, I can move forward with the change. Please create a new GitHub issue detailing the issue that you corrected, then I can merge the pull request. Thanks, Mike |
RussTreadon-NOAA
approved these changes
Jun 12, 2020
|
Closes issue #15 |
MichaelLueken
approved these changes
Jun 12, 2020
lbi2018
pushed a commit
to lbi2018/GSI
that referenced
this pull request
Mar 4, 2022
…variable for regional FV3 DA (NOAA-EMC#12) *Bug fix for EnKF analysis steps when using t (tv) as a control vector variable for regional FV3 DA. *Whitespace and indentation clean-ups were made in src/enkf/gridio_fv3reg.f90. Notes: This PR addresses issue NOAA-EMC#13, which was reported by Jonathan Poterjoy (UMD). And this bug should have affected all the EnKF steps (mean, update, recenter, etc.) The bug fix is based on the diagnoses and discussions among @BinLiu-NOAA and @TingLei-NOAA (EMC), @XL-OU, Jonathan Poterjoy (UMD), Jason Sippel (HRD), etc.
hu5970
referenced
this pull request
in hu5970/GSI
Apr 8, 2022
…nd (#12) 2m temperature is sensible temperature now. The convert from 2m potential temperature to 2m temperature happens during background IO stage.
DavidHuber-NOAA
pushed a commit
to DavidHuber-NOAA/GSI
that referenced
this pull request
Jul 19, 2023
use stack ncdiag, update hera.gnu hpc-stack, update to head of develop
emilyhcliu
pushed a commit
to emilyhcliu/GSI
that referenced
this pull request
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in src/enkf/mpi_readobs, if the ensemble spread in observation space exceeds a value of 1000 a print statement is triggered that tries to print an array (mem_ob) that has already been deallocated. This causes a segfault on Orion. The fix is simply to not print mem_ob.
Does not affect results, but protects against a possible segfault if ensemble spread exceeds the threshold value.