GitHub Issue NOAA-EMC/GSI#344. Changes to monitor new observations from N21, G18, Himawari9 #345
Conversation
|
All 19 regression tests have been run. 18 passed. The test global_fv3_4denvar_C192 failed with an error message below. The memory for global_fv3_4denvar_C192_loproc_updat is 3227036 KBs. This has exceeded maximum allowable hardware memory limit of 2516582 KBs, |
|
Questions / Comments
The test |
MichaelLueken
requested review from
MichaelLueken,
ADCollard,
dtkleist,
emilyhcliu and
RussTreadon-NOAA
|
@RussTreadon-NOAA , thank you very much for running independent tests to examine the impact of these changes. You are correct that the new sensors should be added into the util/oznmon. I will make those changes. For the viirs-m related entries, I will contact Xu Li (I guess those data are related to the nsst work) to see if they should be added into the satype list. Thank you again, Russ. |
1 similar comment
|
@RussTreadon-NOAA , thank you very much for running independent tests to examine the impact of these changes. You are correct that the new sensors should be added into the util/oznmon. I will make those changes. For the viirs-m related entries, I will contact Xu Li (I guess those data are related to the nsst work) to see if they should be added into the satype list. Thank you again, Russ. |
|
When we update We have multiple GFS V16.x PRs altering fix files. For example, this PR, #345, and PR #343 both alter fix files. PR #343 was merged into the master today (3/23/2022). PR #343 updated |
|
Merger of PR #338 into the master conflicts with changes in this PR to Changes to |
| ahi_himawari8 0.00 1.00 90 | ||
| ahi_himawari9 0.00 1.00 90 | ||
| atms_n21 -52.393 1.10 96 | ||
| cris-fsr_n21 -48.130 3.333 30 |
There was a problem hiding this comment.
Question regarding addition of viirs to gdas_radmon_satype.txt already mentioned in this PR. Do similar entries need to be added to gdas_radmon_scaninfo.txt?
There was a problem hiding this comment.
When we update
global_convinfo.txt,global_ozninfo.txt,global_satinfo.txt, orprepobs_errtable.global, we usually update files in or add files tofix/gfsv16_historical. Retrospective parallels often use fix files fromfix/gfsv16_historical. This PR adds new data in monitor mode. Thus, it may not be necessary for this PR to update or add files tofix/gfsv16_historical. It's important to review this point prior to starting GFS v16.x retrospective parallels.We have multiple GFS V16.x PRs altering fix files. For example, this PR, #345, and PR #343 both alter fix files. PR #343 was merged into the master today (3/23/2022). PR #343 updated
global_convinfo.txtandprepobs_errtable.global. These changes do not conflict with this PR. Still care should be taken to ensure the final fix in NOAA-EMC/GSI master contains all GFS v16.x fix changes. It's easy for a desired / required change to be missed or undone.
I will carefully examine the fix directory to make sure this PR have the changes from PR #343
There was a problem hiding this comment.
Changes look good. Some questions / comments posted in PR. The NOAA-EMC/GSI master was updated 3/23/2022 with several PRs. This PR needs to be updated to the new head of the GSI master.
I am not familiar with EFSOI. The changes to EFSOI files in this PR look fine but it would be good to get confirmation from @AndrewEichmann-NOAA .
Good suggestion. Thank you, Russ. Mike, please ask @AndrewEichmann-NOAA and @CatherineThomas-NOAA as reviewers for the changes related to the EFSOI part. |
|
PRs #309, #338, and #343 were merged into the NOAA-EMC/GSI master on 3/23/2022. HaixiaLiu-NOAA/GSI master is 6 commits behind the authoritative master. The forked master must be brought up to date with the authoritative master before this PR can move forward. |
|
@RussTreadon-NOAA My forked master was brought up to date with the authoritative master this morning with @MichaelLueken-NOAA 's help. |
|
Update to head of authoritative master and forked master. Recompile global_gsi.x and rerun 2022032300 gdas case. Two executables generate b4b identical results. These results differ from previous run due to changes in PR #343. Note that new runs are 10-20 seconds longer than previous runs. Consistently see forked master run about 20 seconds longer than authoritative master. Not sure why this is the case since fork is not processing more data. |
|
Thank you @RussTreadon-NOAA for reviewing this PR. I have contacted @AndrewEichmann-NOAA to get him review this PR as well. |
|
@HaixiaLiu-NOAA I don't anticipate the EFSOI changes being a problem. |
|
@AndrewEichmann-NOAA Thank you for confirming. |
|
@HaixiaLiu-NOAA I'm planning on submitting this PR to the review committee tomorrow morning after merging the next update to the authoritative repository. However, there is currently a conflict with the fix submodule that will need to be corrected before this work can be submitted. To correct the fix submodule:
With this, your fork's master will be up-to-date with the current authoritative repository and the conflict in fix should be corrected. If you have any questions or encounter issues, please let me know. |
…r_n21, ompsnp_n21, ompstc8_n21, gome_metop-c, abi_g18, ahi_himawari9, viirs-m_j2
|
@MichaelLueken-NOAA Thank you for the clear instruction. It is done. |
MichaelLueken
changed the title
|
The due date for this update has past with no feedback from the review committee, so I will give final approval to these changes and merge them to the authoritative repository. |
GitHub Issue NOAA-EMC#344. Changes to monitor new observations from N21, G18, Himawari9
There are a list of new observations to be available in operational system from atms_n21, cris-fsr_n21, viirs-m_j2, ompsnp_n21, ompstc8_n21, gome_metop-c, abi_g18 and ahi_himawari9. Changes are made to fix files, src and scripts to monitor these new data. No impact on the analysis is expected from these changes.