GitHub Issue NOAA-EMC/GSI#339. The inclusion of the mixed surface type in situ observations and looser QC for in situ observations

[XuLi-NOAA]

Background

The too warm NSST analysis over the Pamlico Sound area has been reported by MEG people, the diagnosis of the causes has been performed. Besides the correlation length and thinning mesh, the other two causes are: (1) the in situ observations with mixed surface type are not used; (2) The threshold of the O - B QC test is too tight. The PR is to handle these two causes.

See #339

The cycling run, oprcst10 and oprcst2, have been done to test the changes and it shows expected results and the too warm Pamlico Sound issue is resolved.

It is ready to merge to the master.

[XuLi-NOAA]

The regression tests have been done and two of them failed:

89% tests passed, 2 tests failed out of 19

Total Test time (real) = 6737.97 sec

The following tests FAILED:
6 - global_fv3_4denvar_C192 (Failed): non-reproducible result, as expected.
19 - global_C96_fv3aerorad (Failed): This has exceeded maximum allowable operational time of 1200 seconds, this is probably fine.

The RT results: /gpfs/dell2/emc/modeling/noscrub/Xu.Li/regression

The modified fix file is at: /gpfs/dell2/emc/modeling/noscrub/Xu.Li/git/GSI_coast/fix/global_convinfo.txt

[MichaelLueken]

@XuLi-NOAA Who would you like to have review your changes? Please let me know so that I can assign them to your PR. Also, please include:

GitHub Issue NOAA-EMC/GSI#339

To your single commit message. To do this, within your fork's local copy:

1. git commit --amend
2. Add GitHub Issue NOAA-EMC/GSI#339 to the front of the commit message
3. Save and close the commit message
4. git push feature/GSI_coast --force

[XuLi-NOAA]

4. git push feature/GSI_coast --force

Mike,

See

git commit --amend
[master 5c79efd] GitHub Issue #339. Modify setupsst.f90 to include mixed surface in situ observations, modify global_convinfo.txt to loose O-B QC test for in situ observations, and modify exglobal_atmos_analysis.sh for smaller dmesh for surface sensetive radiances for GSI/NSST
Date: Tue Apr 5 02:49:13 2022 +0000
2 files changed, 4 insertions(+), 2 deletions(-)
[Xu.Li@v71a1 GSI_coast]$ git push feature/GSI_coast --force
fatal: 'feature/GSI_coast' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

It seems something else needs to be done as well.

And Andrew and Emily can be the reviewers.

[MichaelLueken]

@XuLi-NOAA I will assign Andrew and Emily to the PR. For the error, please try:

git push origin feature/GSI_coast --force

[XuLi-NOAA]

@XuLi-NOAA I will assign Andrew and Emily to the PR. For the error, please try:

git push origin feature/GSI_coast --force

@MichaelLueken-NOAA : Just realized one question: I should try "git push origin feature/GSI_coast --force" in my branch or master, since I just did one more change (in analysis script, I forgot to di it previously)?

[MichaelLueken]

@XuLi-NOAA All work needs to be in the feature/GSI_coast branch, otherwise it won't make it back to the PR. I see that you have added the modification to scripts/exglobal_atmos_analysis.sh. However, you need to add the issue to the commit message still.

[XuLi-NOAA]

@XuLi-NOAA All work needs to be in the feature/GSI_coast branch, otherwise it won't make it back to the PR. I see that you have added the modification to scripts/exglobal_atmos_analysis.sh. However, you need to add the issue to the commit message still.

@MichaelLueken-NOAA : Got it and everything is OK now?

[MichaelLueken]

@XuLi-NOAA You will need to add the GitHub Issue NOAA-EMC/GSI#339 to the commit message. This isn't in the current commit message associated with this PR. So, within your feature/GSI_coast branch in your fork:

1. git commit --amend
2. Add GitHub Issue NOAA-EMC/GSI#339 to the front of the commit message
3. Save and close the commit message
4. git push origin feature/GSI_coast --force

[XuLi-NOAA]

Done

[ADCollard]

I am happy with these changes.

[MichaelLueken]

The modified fix file is at: /gpfs/dell2/emc/modeling/noscrub/Xu.Li/git/GSI_coast/fix/global_convinfo.txt

@XuLi-NOAA While looking at the differences between the global_convinfo.txt file in fix/rev2 and the modified version above, I see more changes than just the sst entries. I'm seeing the removal of several uv entries that were added by Iliana in f0aa67e (latest fix/rev2 revision) and undoing Emily's ASCAT changes (uv entries) at 384204 (second to last fix/rev2 revision). Looking at the feature/GSI_coast branch in your fork, the fix submodule is up-to-date, so I'm trying to see why the last two updates to the global_convinfo.txt file aren't in your updated version. This will need to be addressed before the modified fix file will be merged to fix/rev2. If you have any questions, please let me know.

[XuLi-NOAA]

The modified fix file is at: /gpfs/dell2/emc/modeling/noscrub/Xu.Li/git/GSI_coast/fix/global_convinfo.txt

@XuLi-NOAA While looking at the differences between the global_convinfo.txt file in fix/rev2 and the modified version above, I see more changes than just the sst entries. I'm seeing the removal of several uv entries that were added by Iliana in f0aa67e (latest fix/rev2 revision) and undoing Emily's ASCAT changes (uv entries) at 384204 (second to last fix/rev2 revision). Looking at the feature/GSI_coast branch in your fork, the fix submodule is up-to-date, so I'm trying to see why the last two updates to the global_convinfo.txt file aren't in your updated version. This will need to be addressed before the modified fix file will be merged to fix/rev2. If you have any questions, please let me know.

@MichaelLueken-NOAA : Yes, this needs to be addressed first. And I don't know the changes related to uv.

[MichaelLueken]

The due date for the review committee has past with no feedback, so I will now give final approval to this update and merge it to the authoritative repository.