Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup a community build system and some bug fixes. #5

Closed
wants to merge 11 commits into from

Conversation

guoqing-noaa
Copy link
Contributor

@guoqing-noaa guoqing-noaa commented Jun 5, 2020

  1. added FV3GFS_NCIO_Fortran_FLAGS for GNU compilers

  2. Moved gsdcloud to src/, make appropriate changes in CMakeLists.txt and a few bug fixes

  3. pietc.f90 and pvqc_tables.f90

    use kinds, only: dp,dpc
--> use kinds, only: r_kind, dp, dpc

This change is to avoid compiling error

error #6580: Name in only-list does not exist or is not accessible. [DP]

Don't know the exact reason, but either (1) removing all #ifdef block in kinds.F90 or (2) use r_kind first can solve this problem.

  1. updated CMakeLists.txt for util/EnKF/arw/src/enspreproc_regional.fd

  2. bug fixes for GNU compilers and regional EnKF.

  3. updated ush/build.comgsi for community users

guoqing-noaa and others added 11 commits June 3, 2020 13:17
add GSD/ wrflib/ bufr/ to src/ (NCEPLIBS did not release bufr lib yet)
Generic.cmake (let it default to use compiled NCEPLIBS)
util/EnKF/arw/src/enspreproc_regional.fd (need to link module_fv3gfs_ncio)
gsdcloudanalysis*.F90 (adjust #ifdef block to solve compiling problems)
src/enkf/gridio_wrf.f90 (update to match lastest gfsv16 updates)
ush/build.comgsi:  adapt to new code structure after transition to Github
lbi2018 pushed a commit to lbi2018/GSI that referenced this pull request Mar 4, 2022
…sda_sync

Sync with the latest support/HAFS, which has been synced with the latest GSI master branch.
There are changes related to the grid_type_fv3_regional development from the master branch, causing some conflicts in the src/gsi/gsi_rfv3io_mod.f90, related to the fv3_h_to_ll and fv3_h_to_ll_regular_grids subroutines. For now, the source code changes related to the grid_type_fv3_regional development are ignored in this merge, which will need to be addressed/unified in the future.
MichaelLueken added a commit that referenced this pull request May 18, 2022
* WIP: cleanup top-level CMakeLists.txt

* clean up ncdiag cmake build

* build global_gsi.x. regional requires something from wrflib

* wcoss_d build

* hierarchy of compiler flags

* Update Intel Fortran flags

* order of includes matter

* install built library and executable for GSI

* Issue #112:  update intel fortran flags, add intel c flags, replace fv3gfs_ncio with ncio module, replace bufr_4_DA with bufr_d

* updates for GNU v10

* add missing files in gsi_files.cmake

* build works with GNU for GSI library and apps.  Install creates package config

* gsi is its own project now

* build GSI and EnKF GFS flavors

* ncdiag, gsi and enkf can be now built independently

* build all (except Monitoring) utilities

* update logic when GSI and EnKF are not found for utilities

* build mods for Orion

* make messages identify their origin

* promote Release instead of Production

* add -DNDEBUG flags for gsi and enkf

* revert whitespace differences that were unintended

* remove obsolete cmake/Modules directory

* remove top-level cmake/ directory

* add host specific flags to module files

* make packages more robust and handle transitive libraries once and done.

* add options for building different components.

* add utilities that are used but did not have CMake builds

* Revert "remove obsolete cmake/Modules directory"

This reverts commit 91fb0ac.

* ncdiag is a requirement since the stubs are obsolete

* add FindMKL.cmake.  Remove finding ncdiag from gsi as a dependency.

* Build changes for WCOSS Dell

* Make necessary changes to allow feature/cmake-refactor to run regression tests: (#1)

Changes from @MichaelLueken-NOAA on setting up offline regression testing.

* Build conventional monitoring utilities.  There is a lot of repeated code in these and could benefit from making a library rather than copy/paste of the same code for each utility.

* Build Radiance and Ozone monitoring utilities.  There is a lot of repeated code in these and could benefit from making a library rather than copy/paste of the same code for each utility.

* retain trailing white spaces to minimize diffs

* add place-holder for regression testing

* remove dependency on NDATE from regression tests.  Use Unix date instead.

* reinstate regression testing via ctest.

* Fix duplicate definition of MPI variables (#3)

* Fix duplicate definition of MPI variables
* Replace "include mpif.h" with "use mpi"

* minor update to EnKF/CMakeLists.txt

* reinstate regression tests w/ ctest

* remove stale cmake/Modules

* remove broken Debug CPP definitions from ncdiag library

* Build with GNU and CMAKE_BUILD_TYPE=Debug

* make DEBUG Intel flags consistent

* allow users to provide CMAKE_OPTS without having to edit the script

* make util build options consistent

* Fix logical comparison bug caught by Gnu build (#4)

* bugfix for cheyenne

* fix logical comparison

* build cleanly

* fix improper character array allocation in fv3reg

* cleanup the build script to allow substantial user control

* add wrapper for NCO build script.
Address GFS adaptation for NCO requirement of "pruning"
Add BUILD_UTIL_ALL option for convenience

* update INSTALL.md to add BUILD_UTIL_ALL option

* trap pruning error

* fix the error with machine_id for cray and dell

* fix the error with machine_id for cray and dell

* update cmake version in orion modulefile

* update ncio to v1.1.0

* consolidate common modulefiles in a modulefile.ProdGSI.common

* add intel and gnu modulefiles for Cheyenne from Chris Harrop

* retain only common modules in modulefile.ProdGSI.common;

* add missing #%Module in the common modulefile

* revert back to ncio/1.0.0

* Fixes for Cheyenne and Jet (#5)

* Fix duplicate MPI definitions in EFSOI exposed by Cheyenne build

Set CC, FC, CXX explicitly for Cheyenne GNU to avoid
use of incorrect MPI module.

Update w3emc to version 2.9.2.

* Fix MPI API call bug that passed mpi_status type instead of a status variable

* Revert version of w3emc and update cmake version for Jet

* remove build.comgsi as it is unlikely to work with the current refactor. Use the `build.sh` instead

* Keeping up with #369, where only some of the modulefiles were updated to lua.

* convert remaining modulefiles to lua.

* modulefile.ProdGSI.common.lua was buggy.  a source code change slipped through via one of the many merged PRs

* remove prod_util from common and load in the platform itself

* since we are changing modulefiles, make their names short and consistent with other applications

* wcoss_dell_p3 cmake is from hpc-stack. Fix that.
update detect_machine.sh and module-setup.sh for wcoss2.
be smart in auto-detection.
fix warnings in source codes.

* protect against accidental commits of binaries

* explicitly use calls from MPI module

Co-authored-by: russ.treadon <Russ.Treadon@noaa.gov>
Co-authored-by: Rahul Mahajan <rmahajan@ice.local>
Co-authored-by: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Co-authored-by: Christopher Harrop <35781497+christopherwharrop-noaa@users.noreply.github.com>
shoyokota pushed a commit to shoyokota/GSI that referenced this pull request Jul 7, 2022
@daviddowellNOAA daviddowellNOAA mentioned this pull request Aug 22, 2023
9 tasks
ShunLiu-NOAA pushed a commit that referenced this pull request Sep 29, 2023
… (see issue #601) (#614)

Adding code to analyze the siginificant wave heigh in GSI 3D Analysis,
esp. for FV3-LAM model based DA, eg. RRFS-DA, RRFS-3DRTMA. (Also see the
issue in EMC GSI github repository: #601
 Adding I/O for Analysis of Significant Wave Height for 3DRTMA)

<!-- PLEASE READ -->
<!--
Before opening a PR, please note these guidelines:

- Each PR should only address ONE topic and have an associated issue
- No hardcoded or paths to personal directories should be present
- No temporary or backup files should be committed
- Any code that was disabled by being commented out should be removed
-->

**Description**

<!-- Please include relevant motivation and context. -->
Significant Wave Height (hereafter as SWH) is one of the standard
products provided by the operational (2D)RTMA. To continuously provide
the same products in 3DRTMA, the next-generation RTMA, some efforts in
GSI code need to be made in order to analyze the SWH in 3D analysis of
GSI.
<!-- Please include a summary of the change and which issue is fixed.
-->
The kernel subroutines to assimilate SWH in GSI (such as stphowv.f90,
setuphowv.f90, inthowv.f90, gsi_howvOper.f90 and m_howvNode.f90) already
had been added for (2D)RTMA years ago by Manuel Pondeca, so for this
issue, the code work mainly focus on adding the I/O of SWH in background
and analysis fields for 3DRTMA (esp. RRFS-based 3DRTMA), and some
necessary modifications in background error, options, variables related
to analysis of SWH, etc.
Modified code in GSI:
1. rapidrefresh_cldsurf_mod.f90: adding a few variables related to the
analysis of howv in 3D analysis
2. gsimod.F90: adding namelist options used for analysis of howv in 3D
analysis
3. m_berror_stats_reg.f90: added some code for the special treatment to
the static background error (BE) of howv
4. read_prepbufr.f90: adding code to decode the observation of howv in
prepbufr file when howv is available in firstguess
5. setuphowv.f90: adding code to use obs of howv when howv is available
in firstguess
6. gsi_rfv3io_mod.f90: adding I/O code to read in howv from firstguess
and write out howv into analysis.


<!-- List any dependencies that are required for this change. -->
No dependencies are required for this change.
<!-- Please provide reference to the issue this pull request is
addressing. -->
This PR is addressing the issue
[#601](#601): Adding code to
analyze the siginificant wave heigh in GSI 3D Analysis".
<!-- For e.g. Fixes #IssueNumber -->
Fixes #601

**Type of change**

Please delete options that are not relevant.


- [*] New feature (non-breaking change which adds functionality)



**How Has This Been Tested?**

<!-- Please describe the tests that you ran to verify your changes and
on the platforms these tests were conducted. -->
- Brief results from ctest (regression test) with the modified code (on
WCOSS2 - Cactus):

 [gang.zhao@clogin07:build] (feature/3drtma_howv)$ ctest -N
Test project /lfs/h2/emc/da/save/gang.zhao/WorkDir/WaveHgt/develop/build
  Test #1: global_3dvar
  Test #2: global_4dvar
  Test #3: global_4denvar
  Test #4: hwrf_nmm_d2
  Test #5: hwrf_nmm_d3
  Test #6: rtma
  Test #7: rrfs_3denvar_glbens
  Test #8: netcdf_fv3_regional
  Test #9: global_enkf

Total Tests: 9
  Test #1: global_3dvar
[gang.zhao@clogin04:build] (feature/3drtma_howv)$ ctest -R global_3dvar
Test project /lfs/h2/emc/da/save/gang.zhao/WorkDir/WaveHgt/develop/build
    Start 1: global_3dvar
1/1 Test #1: global_3dvar .....................   Passed  1631.12 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) = 1631.14 sec

  Test #2: global_4dvar
[gang.zhao@clogin09:build] (feature/3drtma_howv)$ ctest -R global_4dvar
Test project /lfs/h2/emc/da/save/gang.zhao/WorkDir/WaveHgt/develop/build
    Start 2: global_4dvar
1/1 Test #2: global_4dvar .....................   Passed  2462.19 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) = 2462.23 sec

  Test #3: global_4denvar
[gang.zhao@clogin04:build] (feature/3drtma_howv)$ ctest -R
global_4denvar
Test project /lfs/h2/emc/da/save/gang.zhao/WorkDir/WaveHgt/develop/build
    Start 3: global_4denvar
1/1 Test #3: global_4denvar ...................   Passed  1922.43 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) = 1922.46 sec

  Test #4: hwrf_nmm_d2
[gang.zhao@clogin09:build] (feature/3drtma_howv)$ ctest -R hwrf_nmm_d2
Test project /lfs/h2/emc/da/save/gang.zhao/WorkDir/WaveHgt/develop/build
    Start 4: hwrf_nmm_d2
1/1 Test #4: hwrf_nmm_d2 ......................   Passed  1214.10 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) = 1214.20 sec

  Test #5: hwrf_nmm_d3
[gang.zhao@clogin09:build] (feature/3drtma_howv)$ ctest -R hwrf_nmm_d3
Test project /lfs/h2/emc/da/save/gang.zhao/WorkDir/WaveHgt/develop/build
    Start 5: hwrf_nmm_d3
1/1 Test #5: hwrf_nmm_d3 ......................   Passed  736.38 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) = 736.50 sec

  Test #6: rtma
[gang.zhao@clogin05:build] (feature/3drtma_howv)$ ctest -R rtma
Test project /lfs/h2/emc/da/save/gang.zhao/WorkDir/WaveHgt/develop/build
    Start 6: rtma
1/1 Test #6: rtma .............................   Passed  1027.01 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) = 1027.01 sec

  Test #7: rrfs_3denvar_glbens
[gang.zhao@clogin06:build] (feature/3drtma_howv)$ ctest -R
rrfs_3denvar_glbens
Test project /lfs/h2/emc/da/save/gang.zhao/WorkDir/WaveHgt/develop/build
    Start 7: rrfs_3denvar_glbens
1/1 Test #7: rrfs_3denvar_glbens ..............   Passed  484.69 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) = 484.70 sec

  Test #8: netcdf_fv3_regional
[gang.zhao@clogin03:build] (feature/3drtma_howv)$ ctest -R
netcdf_fv3_regional
Test project /lfs/h2/emc/da/save/gang.zhao/WorkDir/WaveHgt/develop/build
    Start 8: netcdf_fv3_regional
1/1 Test #8: netcdf_fv3_regional ..............   Passed  483.08 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) = 483.11 sec

  Test #9: global_enkf
[gang.zhao@clogin03:build] (feature/3drtma_howv)$ ctest -R global_enkf
Test project /lfs/h2/emc/da/save/gang.zhao/WorkDir/WaveHgt/develop/build
    Start 9: global_enkf
1/1 Test #9: global_enkf ......................   Passed  488.50 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) = 488.57 sec

- The modified GSI code passed the regression tests (all 9 tasks) on
Hera and WCOSS2 (Cactus).

- adding the analysis of howv only has very trial influences on the
analyses of other variables. Here is the statistics of the differences
of other variables (u/v/t/ps/q/t2m/q2m) from the runs of GSI without
howv vs. with howv (from a testing case 2023-07-12_14:00:00 UTC in 3km
North-American domain):

comparing two netcdf files:
fcst_fv3lam_hyb_betas/INPUT/fv_core.res.tile1.nc
fcst_fv3lam_nodata_noinfo/INPUT/fv_core.res.tile1.nc ...
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
u / 602135550 3926.84 25760.8 -0.1026 0.485788 0.588388 6.52152e-06
0.00115817
v / 620166777 -4891.34 32582.5 -0.835774 0.268402 1.10418 -7.88714e-06
0.00197793
T / 155987083 178.048 6497.51 -0.0246582 0.0384064 0.0630646 1.14143e-06
0.000218737
delp / 19559676 -281.532 3008.29 -0.00292969 0.00219727 0.00512695
-1.43935e-05 0.000183727

comparing two netcdf files:
fcst_fv3lam_hyb_betas/INPUT/fv_tracer.res.tile1.nc
fcst_fv3lam_nodata_noinfo/INPUT/fv_tracer.res.tile1.nc ...
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
sphum / 430707614 0.594287 2.77816 -2.6139e-05 3.1759e-05 5.7898e-05
1.37979e-09 8.03072e-08

comparing two netcdf files: fcst_fv3lam_hyb_betas/INPUT/sfc_data.nc
fcst_fv3lam_nodata_noinfo/INPUT/sfc_data.nc ...
Variable Group Count Sum AbsSum Min Max Range Mean StdDev
t2m / 10665000 43.3899 135.095 -0.00152825 0.00686629 0.00839454
4.06844e-06 5.02866e-05
q2m / 10665000 0.0192553 0.124707 -3.1476e-06 1.77554e-05 2.0903e-05
1.80547e-09 5.89657e-08

It could be seen that the differences are trivial and ignorable.

<!-- Provide instructions so we can reproduce. -->
The regression tests were done by following the instructions of "[GSI
Ctests (regression
tests)](https://github.com/NOAA-EMC/GSI/wiki/GSI-Ctests-(regression-tests))"
in [GSI Wiki](https://github.com/NOAA-EMC/GSI/wiki)
<!-- Please also list any relevant details for your test configuration
-->
The modified code had also been tested with a testing case
2023-07-12_14:00:00 UTC for 3km North-American domain
Here is a brief summary of the test results:
1. Here is the analysis increment of Significant Wave Height (aka howv
hereafter): pure 3dvar, static background error of howv is 0.42 meters,
and the de-correlation length scale is 170km.

![HOWV_var_inc_maprll_datll_reg_ncf](https://github.com/NOAA-EMC/GSI/assets/53267411/4fdeeb82-7258-4344-be69-cce747474312)
2. The following figure shows the distribution of howv in the analysis
(used obs is in green, rejected in red). Obviously the location of used
obs of howv match the area of non-zero analysis increments of howv.

![var_obs_2023071214_howv_maprll_datll_reg_ncf](https://github.com/NOAA-EMC/GSI/assets/53267411/d4ed6013-cfc8-486e-8f47-db07ec0e4e53)
3. The following figure is the analysis increment of howv with hybrid
envar analysis (using gdas ensemble 80 members and the ensemble weight
is 84%), and the static BE of howv is tuned/inflated. The analysis
increments are very similar to the results from pure 3dvar run (see the
first figure)

![HOWV_hyb_betas016_inc_maprll_datll_reg_ncf](https://github.com/NOAA-EMC/GSI/assets/53267411/e6e696e8-932b-42ab-9001-3472e970b21c)
4. The last figure shows the analysis increments of howv with hybrid
envar analysis (using gdas ensemble 80 members and the ensemble weight
is 84%), but the static BE of howv is NOT tuned. It can be observed that
the analysis increments is less than the results from the hybrid run
with tuning the static BE of howv. That is because the weight of static
BE (16%) reduced the background error of howv (ensemble of howv is not
available yet), so the impact of obs is decreased.

![HOWV_hyb_betas016_noTune_inc_maprll_datll_reg_ncf](https://github.com/NOAA-EMC/GSI/assets/53267411/ca25d068-fc86-4d47-a9d2-46e02ac22dac)

  
**Checklist**

- [*] My code follows the style guidelines of this project
- [*] I have performed a self-review of my own code
- [*] I have commented my code, particularly in hard-to-understand areas
- [*] New and existing tests pass with my changes
- [*] Any dependent changes have been merged and published

**DUE DATE for this PR is 10/5/2023.** If this PR is not merged into
`develop` by this date, the PR will be closed and returned to the
developer.
@ShunLiu-NOAA ShunLiu-NOAA mentioned this pull request Oct 4, 2023
9 tasks
@JingCheng-NOAA JingCheng-NOAA mentioned this pull request Oct 26, 2023
8 tasks
@hongli-wang hongli-wang mentioned this pull request Oct 27, 2023
6 tasks
@wx20jjung wx20jjung mentioned this pull request Feb 26, 2024
1 task
@xincjin-NOAA xincjin-NOAA mentioned this pull request Mar 1, 2024
7 tasks
ShunLiu-NOAA pushed a commit that referenced this pull request Mar 27, 2024
**DUE DATE for merger of this PR into `develop` is 2/19/2024 (six weeks
after PR creation).**
**DUE DATE for this PR is extended to 3/19/2024 because @XuLu-NOAA is on
leave.**
**Description**

Xu Lu (xu.lu@noaa.gov) and Biju Thomas (biju.thomas@noaa.gov) fixed bugs
regarding HAFS GSI debug build and run issues. This is in corresponding
to issue #661

Fixes #661

1. In read_radar.f90, uninitialized toff is making all the ground-based
radar observations be placed at -3h instead of 0h, which creates wrong
increments for FGAT and 4DEnVar.
2. In read_radar.f90, uninitialized zsges will crash the debug mode.
3. In read_radar.f90, t4dvo should be used instead of t4dv in the
read_radar_l2rw_novadqc subroutine.
4. In radinfo.90, maxscan should be increased to at least 252 to allow
more scans, or it will crash the debug mode.
5. In read_fl_hdob.f90, dlnpsob is replaced with 1000. since the SFMR
does not sample surface pressure, and the uninitialized dlnpsob creates
issues later in setupspd.f90 in the debug mode.
6. In mod_fv3_lola.f90, (i,j+1) should be used instead of (i+1,j) in
searching for V edges.
7. In stpcalc.f90, when tried to find the best stepsize from outpen
around L838-864, the minimum outstp(i) is stored in stp(ii), but the
istp_use is asigned with i instead of ii. Create inconsistency when
assigning stp(istp_use) to stpinout at L872. Should use istp_use=ii
instead.

**Type of change**
- [Yes] Bug fix (non-breaking change which fixes an issue)

**How Has This Been Tested?**
Regression test on Orion:
```
Test project /work/noaa/hwrf/save/xulu/mergeversions/GSI/build
CMake Warning (dev) at CTestTestfile.cmake:9 (subdirs):  Syntax Warning in cmake code at /work/noaa/hwrf/save/xulu/mergeversions/GSI/build/regression/CTestTestfile.cmake:7:10
1/7 Test #4: [=[netcdf_fv3_regional]=] ........   Passed  365.11 sec
2/7 Test #7: [=[global_enkf]=] ................   Passed  430.29 sec
3/7 Test #3: [=[rrfs_3denvar_glbens]=] ........   Passed  605.35 sec
4/7 Test #2: [=[rtma]=] .......................   Passed  969.78 sec
5/7 Test #6: [=[hafs_3denvar_hybens]=] ........***Failed  1455.47 sec
6/7 Test #1: [=[global_4denvar]=] .............   Passed  1682.40 sec
7/7 Test #5: [=[hafs_4denvar_glbens]=] ........***Failed  1758.90 sec
```

The failed hafs_3denvar and 4denvar are within expectation due to the
fix for toff. As demonstrated in the single observation tests in the
following figure, the uninitialized toff can result in increment
degradations due to wrongly assigned observation times:

![image](https://github.com/NOAA-EMC/GSI/assets/26603014/0de870e1-f8c8-4b6d-8039-57f417b76367)
ShunLiu-NOAA pushed a commit that referenced this pull request Apr 5, 2024
…ed 3DRTMA (#730)

<!-- PLEASE READ -->
<!--
Before opening a PR, please note these guidelines:

- Each PR should only address ONE topic and have an associated issue
- No hardcoded or paths to personal directories should be present
- No temporary or backup files should be committed
- Any code that was disabled by being commented out should be removed
-->

**Description**

<!-- Please include relevant motivation and context. -->
<!-- Please include a summary of the change and which issue is fixed.
-->
<!-- List any dependencies that are required for this change. -->
To improve the analysis of the near-surface wind gust in 3DRTMA, the
observations of near-surface wind gust would be analyzed directly in GSI
(3DVar and Hybrid 3DEnVar), instead of being a derived product from the
near-surface wind analysis.

Since the core subroutines for direct variational assimilation of wind
gust (e.g., setupgust.f90, intgust.f90, stpgust.f90, etc.) had already
been implemented in GSI for 2DRTMA, so in the work the development in
GSI mainly focus on adding I/O of 2-D wind gust firstguess and analysis
fields for RRFS-based 3DRTMA, and some minor modifications in
observation and background error for wind gust, options to control the
analysis of wind gust, etc.
<!-- Please provide reference to the issue this pull request is
addressing. -->
<!-- For e.g. Fixes #IssueNumber -->
This PR is to address the issue #726 : Adding I/O for direct analysis of
near-surface wind gust for RRFS-based 3DRTMA
Fixes #726
**Type of change**

Please delete options that are not relevant.

- [x] New feature (non-breaking change which adds functionality)

**How Has This Been Tested?**

<!-- Please describe the tests that you ran to verify your changes and
on the platforms these tests were conducted. -->
<!-- Provide instructions so we can reproduce. -->
<!-- Please also list any relevant details for your test configuration
-->
  
**Checklist**

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] New and existing tests pass with my changes
      tested with a real case - 2024-02-20_12:00Z, 
1. dry-run (using my updated GSI code with wind gust analysis, but
actually no wind gust obs is analyzed, so-called dryrun) is compared to
control-run (original GSI code running without wind gust obs): the
results are identical. This indicates that if without analyzing
wind-gust obs, then the updated code generates the analysis identical to
the analysis of original/control code. Or say, the added code does not
have influence on the other part of code.
2. real case run with updated GSI code to analyze the obs of wind gust:
The following figure shows the used observations of near-surface wind
gust:

![var_obs_2024022012_gust_used_maprll_datll_reg_ncf](https://github.com/NOAA-EMC/GSI/assets/53267411/ecbe479a-03c6-490f-a179-9e0027291468)
the following figure shows the analysis increments:

![GUST_hyb_hwllp90_corptuned_inc_incrintrp_maprll_datrll_reg_grb2](https://github.com/NOAA-EMC/GSI/assets/53267411/a01fca0d-dc1f-438b-b8eb-e624de35a631)
- [x] Any dependent changes have been merged and published
- [x] Regression tests on WCOSS2 (Cactus) and Hera (Rocky-8) : my
updated GSI commit
[#f91f247d](GangZhao-NOAA@f91f247))
vs control/original GSI code (commit
[#6d9ebbb7](6d9ebbb))
Here is the reports of the regression tests on WCOSS2 (Cactus):
~~~
[gang.zhao@clogin02:build] (feature/windgust_in_3dvar_for_3drtma)$ ctest
-j 7
Test project
/lfs/h2/emc/da/save/gang.zhao/WorkDir/ProdGSI_Dev/gsi_dev/build
    Start 1: global_4denvar
    Start 2: rtma
    Start 3: rrfs_3denvar_glbens
    Start 4: netcdf_fv3_regional
    Start 5: hafs_4denvar_glbens
    Start 6: hafs_3denvar_hybens
    Start 7: global_enkf
1/7 Test #4: netcdf_fv3_regional ..............   Passed  483.15 sec
2/7 Test #3: rrfs_3denvar_glbens ..............   Passed  486.74 sec
3/7 Test #7: global_enkf ......................   Passed  850.98 sec
4/7 Test #2: rtma .............................   Passed  970.28 sec
5/7 Test #6: hafs_3denvar_hybens ..............   Passed  1152.82 sec
6/7 Test #5: hafs_4denvar_glbens ..............   Passed  1213.93 sec
7/7 Test #1: global_4denvar ...................   Passed  1683.16 sec

100% tests passed, 0 tests failed out of 7

Total Test time (real) = 1683.19 sec
~~~
Here is the reports of the regression tests on Hera (Rocky8):
~~~
(base) [Gang.Zhao@hfe11:build] (feature/windgust_in_3dvar_for_3drtma)$
ctest -j 7
Test project /scratch1/NCEPDEV/da/Gang.Zhao/ProdGSI_dev/gsi_dev/build
    Start 1: global_4denvar
    Start 2: rtma
    Start 3: rrfs_3denvar_glbens
    Start 4: netcdf_fv3_regional
    Start 5: hafs_4denvar_glbens
    Start 6: hafs_3denvar_hybens
    Start 7: global_enkf
1/7 Test #4: netcdf_fv3_regional ..............   Passed  491.53 sec
2/7 Test #3: rrfs_3denvar_glbens ..............***Failed  495.27 sec
3/7 Test #2: rtma .............................   Passed  982.45 sec
4/7 Test #6: hafs_3denvar_hybens ..............   Passed  1168.99 sec
5/7 Test #7: global_enkf ......................   Passed  1239.77 sec
6/7 Test #5: hafs_4denvar_glbens ..............***Failed  1347.87 sec
7/7 Test #1: global_4denvar ...................   Passed  1974.45 sec

71% tests passed, 2 tests failed out of 7

Total Test time (real) = 1974.91 sec

The following tests FAILED:
          3 - rrfs_3denvar_glbens (Failed)
          5 - hafs_4denvar_glbens (Failed)
Errors while running CTest
Output from these tests are in:
/scratch1/NCEPDEV/da/Gang.Zhao/ProdGSI_dev/gsi_dev/build/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases
verbosely.
(base) [Gang.Zhao@hfe11:build] (feature/windgust_in_3dvar_for_3drtma)$
ctest -R rrfs_3denvar_glbens
Test project /scratch1/NCEPDEV/da/Gang.Zhao/ProdGSI_dev/gsi_dev/build
    Start 3: rrfs_3denvar_glbens
1/1 Test #3: rrfs_3denvar_glbens ..............   Passed  430.52 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) = 430.55 sec
(base) [Gang.Zhao@hfe11:build] (feature/windgust_in_3dvar_for_3drtma)$
ctest -R hafs_4denvar_glbens
Test project /scratch1/NCEPDEV/da/Gang.Zhao/ProdGSI_dev/gsi_dev/build
    Start 5: hafs_4denvar_glbens
1/1 Test #5: hafs_4denvar_glbens ..............   Passed  1225.37 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) = 1225.39 sec
~~~
**Note**: 
_When I was running the regression tests, GSI code was just updated to
the latest commit
[#b53740a7](GangZhao-NOAA@f91f247).
Considering the frequent update in EMC GSI code recently and saving the
time, after this PR has been reviewed and approved by peer-reviewers, I
will update the code to latest EMC GSI commit, then re-run the
regression tests for final approval.
@ADCollard ADCollard mentioned this pull request Apr 17, 2024
5 tasks
@ShunLiu-NOAA ShunLiu-NOAA mentioned this pull request Apr 29, 2024
9 tasks
@wx20jjung wx20jjung mentioned this pull request Jul 11, 2024
7 tasks
@wx20jjung wx20jjung mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant