Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://github.com/ufs-community/ufs-weather-model/issues/1632 #643

Merged
merged 14 commits into from
Mar 3, 2023

Conversation

SamuelTrahanNOAA
Copy link
Contributor

This adds lightning threat indexes calculated from within the model. The UPP already knows how to output these since it is a HRRR operational product. These changes copy the fields from FV3 to the relevant variables in VRBLS2D.f. Also, I disabled in FV3LAM the non-functional IGET(444) lightning threat index that is output as all 0s, and corrected the output logic so it is presented as a statistical field.

Issue is here:

ufs-community/ufs-weather-model#1632

@WenMeng-NOAA
Copy link
Collaborator

@SamuelTrahanNOAA Do you have the sample RRFS model files to test new lighting threat index?

@SamuelTrahanNOAA
Copy link
Contributor Author

@SamuelTrahanNOAA Do you have the sample RRFS model files to test new lighting threat index?

Yes, but if you have 3km RRFS files already, they'll probably produce lightning. You need a lot of upward motion and graupel at the same place.

@WenMeng-NOAA
Copy link
Collaborator

@SamuelTrahanNOAA Do you have the sample RRFS model files to test new lighting threat index?

Yes, but if you have 3km RRFS files already, they'll probably produce lightning. You need a lot of upward motion and graupel at the same place.

There aren't three lightning fields in the RRFS model files I archived. It would be good if you can provide me RRFS files to test the capability of reading lightning fields from model.

@WenMeng-NOAA
Copy link
Collaborator

@SamuelTrahanNOAA Can you add change logs in INITPOST_NETCDF.f and MDL2AGL.f?

@SamuelTrahanNOAA
Copy link
Contributor Author

Can you add change logs in INITPOST_NETCDF.f and MDL2AGL.f?

Done.

@SamuelTrahanNOAA
Copy link
Contributor Author

You can find output from the post with the lightning fields in this directory:

HERA: /scratch2/BMC/wrfruc/Samuel.Trahan/lightning/sample-lightning-rrfs-3km-2023020912/post

@WenMeng-NOAA
Copy link
Collaborator

You can find output from the post with the lightning fields in this directory:

HERA: /scratch2/BMC/wrfruc/Samuel.Trahan/lightning/sample-lightning-rrfs-3km-2023020912/post

My test is at /scratch1/NCEPDEV/stmp2/Wen.Meng/post_rrfs_2023020912 on Hera.
I saw new lightning product in NATLEV08.tm00 as:

1309:1136963285:ndata=1905141:undef=0:mean=0.00189482:min=0:max=18:cos_wt_mean=0.00203118:d=2023020912:LTNG:entire atmosphere:7-8 hour max fcst:

Please let me know if you anything inconsistent with your test. @SamuelTrahanNOAA

@WenMeng-NOAA
Copy link
Collaborator

@EdwardColon-NOAA The output of lightning products from UPP is fixed in this PR. You might find one lightning product is able to be generated in the rtma WRFTWO dataset as:

52:32145805:d=2020113000:LTNG:entire atmosphere:0-0 day max fcst:

Please let me know if you have concerns.

@SamuelTrahanNOAA
Copy link
Contributor Author

The output of lightning products from UPP is fixed in this PR

I lack context, but that may not be true, depending on which LTNG product he was using. I fixed the one that copies the maximum hourly lightning threat index from the model. There's another LTNG as IGET(444) which I did not touch.

@EdwardColon-NOAA
Copy link
Contributor

EdwardColon-NOAA commented Mar 3, 2023 via email

@WenMeng-NOAA
Copy link
Collaborator

Thank you Wen. We normally don’t look at the lightning product for UPP output but it is good to have.
-Edward
On Fri, Mar 3, 2023 at 10:56 AM Samuel Trahan (NOAA contractor) < @.> wrote: The output of lightning products from UPP is fixed in this PR I lack context, but that may not be true, depending on which LTNG product he was using. I fixed the one that copies the maximum hourly lightning threat index from the model. There's another LTNG as IGET(444) which I did not touch. — Reply to this email directly, view it on GitHub <#643 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACFXXQFEXDUUORWKYHI3LL3W2IICLANCNFSM6AAAAAAVJ67XGA . You are receiving this because you were mentioned.Message ID: @.>
-- ------------------------------------------------- Edward Colón Lynker at NOAA/NWS/NCEP/EMC 5830 University Research Ct. Rm #2025 Riverdale, MD 20737 Office: (301) 683-3815 Cell: (301) 213-3566

@EdwardColon-NOAA Thanks for clarifying.

@WenMeng-NOAA
Copy link
Collaborator

The output of lightning products from UPP is fixed in this PR

I lack context, but that may not be true, depending on which LTNG product he was using. I fixed the one that copies the maximum hourly lightning threat index from the model. There's another LTNG as IGET(444) which I did not touch.

@SamuelTrahanNOAA I saw rtma control file includes three LTNG products, 702, 703, 704. With your PR, only 704 is able to be generated. We might address 702 and 703 generation in the future.

@SamuelTrahanNOAA
Copy link
Contributor Author

Internally, the post should have 702 and 703. I don't know why they aren't being written out.

@WenMeng-NOAA
Copy link
Collaborator

Internally, the post should have 702 and 703. I don't know why they aren't being written out.

@SamuelTrahanNOAA It seems grib2 names LTGTHREAT1, LTGTHREAT2 used by 702 and 703 are not officially added in g2tmpl lib. It could be addressed later.

@WenMeng-NOAA
Copy link
Collaborator

The UPP RT tests were completed on WCOSS2, Hera and Orion. The baselines for rrfs and rtma will be recreated with this PR. This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA added RRFS 3DRTMA Ready for Review This PR is ready for code review. Baseline Change The baselines of the UPP regression tests are changed. labels Mar 3, 2023
@WenMeng-NOAA WenMeng-NOAA merged commit e180613 into NOAA-EMC:develop Mar 3, 2023
@WenMeng-NOAA WenMeng-NOAA changed the title Lightning threat indexes calculated inside model https://github.com/ufs-community/ufs-weather-model/issues/1632 Mar 8, 2023
@WenMeng-NOAA WenMeng-NOAA linked an issue Mar 23, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3DRTMA Baseline Change The baselines of the UPP regression tests are changed. Ready for Review This PR is ready for code review. RRFS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Capability of Reading Lightning Threat Indexes from UFS
3 participants