Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update develop from gsd/develop 2020/11/20: Unified gravity wave drag, updates to other GSL physics #202
Update develop from gsd/develop 2020/11/20: Unified gravity wave drag, updates to other GSL physics #202
Changes from 250 commits
b2404b5
2124b57
e726454
cb7e389
a550ddf
1688b29
07af073
661e98c
bc31689
03f7d78
9caa172
ac71e23
2de4377
eae6786
88e87e9
bace3d3
1bb3370
cc0f89a
77bb53e
502ef17
28f8cb3
088ec20
df0e6ea
c7ad1a3
8b16470
dc10a75
9d4959f
53b365f
0dcce97
8789b87
2200678
0d60589
2398c9c
6ec41e8
a15f74b
af8915b
538a1d8
fbc1826
ff725de
7b299c5
f40f215
322c846
d257b2a
e95f8ab
5275fb9
1e0619f
e9eaddf
bc13d22
73586f0
c135174
cf3d933
dd8f27e
9ca064c
1216e7c
e4c9eb8
f4fecfd
ee400da
2c3d99c
e43103d
815476d
3300660
5395a66
b8bcb32
ae4f6be
f23fa37
7a3ab3a
596a0b5
7d4d569
d46ebe8
9f8b18f
71ecc5b
3338fe0
2a05c53
cd2583d
7648548
3972587
78586f4
934cf14
001d24f
859cdd2
ddec8ae
58670cc
c6e032e
544cbe5
5b6a22d
2dd765a
19fb05e
e09316a
fcc27ec
af8c130
0963476
8c8137c
522342e
66e9859
fed81f9
68d4033
1e2a188
6608e46
00953fd
2f78145
9406b7a
ab8d4dd
ab8e41b
13928aa
537df51
893d935
c9ec6e9
e4d2ba8
6b19505
662333a
f43eb0f
f0e8419
c18619c
df3f9e4
ab95ad8
3abf078
e3e84fa
1193c21
bfe13b0
325ebd2
a7cd9d1
f1cfcfd
f87cbd4
dabf9e6
acbc575
3a0490d
94b3ee0
7af8c0a
c441a8e
7b5bdf9
499accf
dec6867
b6411ba
45337f7
289edfc
7ef6827
2a5c1b8
92005bd
df3378e
f9b4dcc
d78e553
71f6e3f
358697c
739da03
27eaec1
c996a9a
eca86da
1d72809
392a0b0
170500c
9795ea7
0883e97
18d2dc1
ac8f47a
4dfe737
4deb117
5dde84c
a249ccb
dc22afe
2ea9d39
06d596e
cef892d
61b8b6d
c73d384
fb31f76
ff91cff
6f26ccf
80732fa
eed6517
1074e93
fb4cc41
f5f7dbd
026b0aa
9f191ae
0db9261
59f6f86
8ad85d3
1c64e70
85f55c2
f3ed818
84c727d
9d2fb58
9bd419c
30f40e8
5811a05
a8d8d93
2b61cd4
6e824a0
e904618
36d546f
707f68d
bd32c9e
b51c4fc
a5a066a
1d8b258
0776fc6
926001c
968ad2e
23b8770
4e6475e
4ff714c
b916806
034d8f2
9b224af
345fd93
936da62
9784248
dc619e5
14f852f
0e07005
00084c0
39fcfe1
4a64b78
b094ffe
5c424d0
c7bfd3c
ebaef7e
0ffbb3c
42bebfc
6b1efbc
d7906d8
48f348e
e3919c2
bf64848
c71cab0
5cdb622
4f638e2
2371123
da639d0
0ac7e4f
bf5cfab
daced91
8061355
bcf422d
f752b12
f5dcd1f
9b8458c
cc2df74
3919ec5
84b00df
ae66853
5e95e56
a664d01
cdd6897
34a9337
c289028
64da3d8
8d1cd72
fdc3543
23423c6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a place holder? tracer_sanitizer seems not used in any suite file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right, the "offending"
tracer_sanitizer
scheme is added in ccpp-physics for testing and debugging stability issues. It's not to be used ever in applications, because it's a dumb scheme that simply resets negative tracers to zero and doesn't care about water conservation. As such, it is commented out everywhere, but the commented lines for the two GSD suites illustrate how we used it in order to stabilize the model. It's similar to the Thompson MP tendency limiter, which simply puts a lid on the heating rate coming out of the Thompson scheme without adjusting any other quantity. I guess we will delete thetracer_sanitizer
and Thompson MP tendency limiter once we figured out how to run the GSL physics in a stable way at reasonable time steps (it's always stable at small timesteps, but these can't be used in operations).