Lightning threat indexes #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… only if model wants it
WenMeng-NOAA
approved these changes
Mar 15, 2023
|
@jkbk2004 @SamuelTrahanNOAA ufs-community/ccpp-physics#42 is merged. Looks like NOAA-GFDL/GFDL_atmos_cubed_sphere#243 needs to be merged next. |
|
@SamuelTrahanNOAA cubed-sphere pr was merged. |
jkbk2004
approved these changes
Mar 24, 2023
BrianCurtis-NOAA
requested changes
Mar 24, 2023
|
The .gitmodules, ccpp/physics, and atmos_cubed_sphere now point to the authoritative branches. |
|
@SamuelTrahanNOAA correct cubed-sphere hash is NOAA-GFDL/GFDL_atmos_cubed_sphere@a4450fb can you revert the change in .gitmodules as well? |
|
Sorry, that was the wrong PR. I just updated this one. It should be right, now. |
BrianCurtis-NOAA
approved these changes
Mar 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calculates the lightning threat index product from HRRR, inside CCPP and sends it to UPP for output.
The algorithm was originally ported from HRRR to the GFDL_atmos_cubed_sphere NGGPS diagnostics, using the w variable in both implementations. I've moved it to CCPP's maximum hourly diagnostics, but it still needs w in the formulation, so I've added the dynamical core's w variable as wgrs to match the u & v winds which are ugrs and vgrs.
Issue(s) addressed
ufs-community/ufs-weather-model#1632
NOAA-EMC/UPP#672
Testing
How were these changes tested?
A 3km test case from a time that had some lightning was run and compared to the HRRR output. Developers of the scheme found the results to be comparable. There'll be more extensive testing after this is merged and running in parallels.
What compilers / HPCs was it tested with?
Hera intel.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
No, because there are no 3km test cases in ufs-weather-model for the RRFS, and the 13km are unable to produce lightning. If someone has an idea for how to fix this, please comment here.
Have the ufs-weather-model regression test been run? On what platform?
Yes, hera.intel, but I'll run again soon after updating to the top of develop.
Many regression test results may change due to updating to the latest UPP and adding fields to regional output.
As you wish.
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs
waiting on Lightning Threat Indexes: pass w to model NOAA-GFDL/GFDL_atmos_cubed_sphere#243
waiting on Lightning threat indexes ufs-community/ccpp-physics#42
waiting on https://github.com/ufs-community/ufs-weather-model/issues/1632 UPP#643waiting on bug fixes needed for running with libIFI UPP#646waiting on
CALSLR_ROEBBER: Instead of calling BOUND incorrectly, use min and max UPP#673