Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field_manager interface cleanup #1317

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Field_manager interface cleanup #1317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77272d2
cleanup field_manager interfaces
Aug 3, 2023
e31929a
fix libFMS
Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions field_manager/field_manager.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,6 @@ module field_manager_mod
public :: field_manager_init !< (nfields, [table_name]) returns number of fields
public :: field_manager_end !< ()
public :: find_field_index !< (model, field_name) or (list_path)
public :: find_field_index_old !< (model, field_name) returns index of field_name in
public :: find_field_index_new
public :: get_field_info !< (n,fld_type,fld_name,model,num_methods)
!! Returns parameters relating to field n.
public :: get_field_method !< (n, m, method) Returns the m-th method of field n
Expand All @@ -222,19 +220,11 @@ module field_manager_mod
public :: fm_get_length !< (list) return length
public :: fm_get_type !< (field) return string
public :: fm_get_value !< (entry, value [, index]) return success !! generic
public :: fm_get_value_integer !< as above (overloaded function)
public :: fm_get_value_logical !< as above (overloaded function)
public :: fm_get_value_real !< as above (overloaded function)
public :: fm_get_value_string !< as above (overloaded function)
public :: fm_init_loop !< (list, iter)
public :: fm_loop_over_list !< (list, name, type, index) return success
!! (iter, name, type, index) return success
public :: fm_new_list !< (list [, create] [, keep]) return index
public :: fm_new_value !< (entry, value [, create] [, index]) return index !! generic
public :: fm_new_value_integer !< as above (overloaded function)
public :: fm_new_value_logical !< as above (overloaded function)
public :: fm_new_value_real !< as above (overloaded function)
public :: fm_new_value_string !< as above (overloaded function)
public :: fm_reset_loop !< ()
public :: fm_return_root !< () return success
public :: fm_modify_name !< (oldname, newname) return success
Expand Down
19 changes: 0 additions & 19 deletions field_manager/fm_util.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,6 @@ module fm_util_mod !{
public fm_util_get_real_array
public fm_util_get_string_array
public fm_util_set_value
public fm_util_set_value_integer_array
public fm_util_set_value_logical_array
public fm_util_set_value_real_array
public fm_util_set_value_string_array
public fm_util_set_value_integer
public fm_util_set_value_logical
public fm_util_set_value_real
public fm_util_set_value_string
!public fm_util_get_index
public fm_util_get_index_list
public fm_util_get_index_string
Expand Down Expand Up @@ -102,17 +94,6 @@ module fm_util_mod !{
! Interface definitions for overloaded routines
!

!interface fm_util_get_value !{
Copy link
Contributor Author

@mlee03 mlee03 Aug 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commented out interface declaration was removed because the procedures under it do not exist.

!module procedure fm_util_get_value_integer
!module procedure fm_util_get_value_logical
!module procedure fm_util_get_value_real
!module procedure fm_util_get_value_string
!module procedure fm_util_get_value_integer_array
!module procedure fm_util_get_value_logical_array
!module procedure fm_util_get_value_real_array
!module procedure fm_util_get_value_string_array
!end interface !}

!> @}

!> @ingroup fm_util_mod
Expand Down
8 changes: 0 additions & 8 deletions libFMS.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,14 +315,6 @@ module fms
fms_fm_util_get_real_array => fm_util_get_real_array, &
fms_fm_util_get_string_array => fm_util_get_string_array, &
fms_fm_util_set_value => fm_util_set_value, &
fms_fm_util_set_value_integer_array => fm_util_set_value_integer_array, &
fms_fm_util_set_value_logical_array => fm_util_set_value_logical_array, &
fms_fm_util_set_value_real_array => fm_util_set_value_real_array, &
fms_fm_util_set_value_string_array => fm_util_set_value_string_array, &
fms_fm_util_set_value_integer => fm_util_set_value_integer, &
fms_fm_util_set_value_logical => fm_util_set_value_logical, &
fms_fm_util_set_value_real => fm_util_set_value_real, &
fms_fm_util_set_value_string => fm_util_set_value_string, &
fms_fm_util_get_index_list => fm_util_get_index_list, &
fms_fm_util_get_index_string => fm_util_get_index_string, &
fms_fm_util_default_caller => fm_util_default_caller
Expand Down