Workaround for Cray compiler bug involving NULL() intrinsic
#1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A workaround has been introduced for a bug in the Cray compiler, where the NULL() intrinsic fails to return a pointer of the correct type. Rather than using NULL() directly as a subroutine argument, it is assigned to a variable which is passed to the subroutines.
laurenchilutti
approved these changes
Jul 26, 2024
rem1776
approved these changes
Aug 27, 2024
|
This bug should be fixed in the next CCE release in a few months, so perhaps this PR doesn't need to be merged. |
|
We should reopen this PR |
rem1776
previously approved these changes
Oct 24, 2024
uramirez8707
requested changes
Oct 24, 2024
diag_manager/fms_diag_object.F90
Outdated
| @@ -224,6 +224,7 @@ integer function fms_register_diag_field_obj & | |||
| integer, allocatable :: file_ids(:) !< The file IDs for this variable | |||
| integer :: i !< For do loops | |||
| integer, allocatable :: diag_field_indices(:) !< indices where the field was found in the yaml | |||
| class(diagDomain_t), pointer :: null_ptr => NULL() !< Workaround for a Cray compiler bug | |||
There was a problem hiding this comment.
can you rename this variable to like null_diag_domain?
bensonr
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Will approve once the change requested by @uramirez8707 is addressed.
uramirez8707
approved these changes
Oct 28, 2024
rem1776
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Cray compiler contains a bug where the
NULL()intrinsic fails to produce a pointer of the correct type when it is passed directly to a subroutine expecting a pointer to a derived type.This PR implements a workaround where
NULL()is assigned to a variable which is passed to the subroutine, rather than callingNULL()directly as a subroutine argument.How Has This Been Tested?
Builds with Cray compiler 15.0.1 on C5.
Checklist:
make distcheckpasses