Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data_override test failures test #1595

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

uramirez8707
Copy link
Contributor

Description
This attempts to fix the now consistent crashes with the data_override unit tests

FATAL from PE     1: NetCDF: Unknown file format: netcdf_file_open:INPUT/grid_spec.nc

The scripts now create the files, and then run the model rather than it all being the same run.

Fixes #1480

How Has This Been Tested?
CI (successfully passed the tests twice)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@uramirez8707 uramirez8707 requested a review from rem1776 as a code owner October 3, 2024 19:51
Copy link
Contributor

@rem1776 rem1776 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for separating this fix!

@rem1776 rem1776 merged commit 85475e5 into NOAA-GFDL:main Oct 3, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_data_override sporadic failures in CI testing
2 participants