Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactorization: simplify setting of Time_start and Time at nc=0 #116

Open
mlee03 opened this issue May 18, 2024 · 0 comments
Open

refactorization: simplify setting of Time_start and Time at nc=0 #116

mlee03 opened this issue May 18, 2024 · 0 comments

Comments

@mlee03
Copy link
Contributor

mlee03 commented May 18, 2024

In full coupler_main, Time at nc=0 and Time_init are set through a convoluted process in subroutine coupler_init.

For Time at nc=0,

  1. Time = date where date is specified in the third line in the coupler.res file.
  2. If coupler.res does not exist or if the user specifies force_date_from_namelist=.True., Time = current_date where current_date is specified in the namelist.
  3. If coupler_init is resorted to using current_date and current_date is not of appropriate value, mpp_error is called.

Initially, Time_init=date_init where date_init is specified in the second line of coupler.res. This value is eventually overwritten to be Tiime_init=base_date where base_date is specified in the diag_table. If the base_year=0 from the diag_table, date_init=date where date had been determined as above description.

Setting of Time and Time_init should be straightfoward and only method route should be available to the user.
Refining the setting of Time and Time_init also opens up a chance to discuss the need of the coupler.res file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant