Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactorization: coupler_clock object #120

Open
mlee03 opened this issue May 30, 2024 · 1 comment
Open

refactorization: coupler_clock object #120

mlee03 opened this issue May 30, 2024 · 1 comment

Comments

@mlee03
Copy link
Contributor

mlee03 commented May 30, 2024

The derived type coupler_clock_type consists of (integer) clock ids and has been introduced as part of full coupler_main refactorization. Because of the frequency in which these ids are retrieved in coupler_main, all components of coupler_clock_type have initially been made public.

However, to be consistent with current FMS developments to objectify all derived types - making derived types components private and introducing "getters" and "setter" type-bound procedures, the following changes should be made:

  1. All ids should be made private.
  2. Type-bound functions to retrieve clock ids should be introduced.
  3. Existing clock-related subroutine coupler_set_clock_ids should be made into a type-bound subroutine.
@mlee03
Copy link
Contributor Author

mlee03 commented May 30, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant