Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ufs-release/public-v2: initialized cld_amt to zero for regional runs #62

Merged

Conversation

climbfuji
Copy link

@climbfuji climbfuji commented Dec 2, 2020

Description

This PR contains a one-liner change in model/fv_regional_bc.F90 to initialize cld_amt to zero so that regional runs using GFDL microphysics can be initialized from input data that doesn't contain cld_amt (e.g. RAP/HRRR input data).

Testing

See ufs-community/ufs-weather-model#313

Dependencies

#62
NOAA-EMC/fv3atm#207
ufs-community/ufs-weather-model#313

@climbfuji
Copy link
Author

@bensonr Hopefully the second-to-last PR for the ufs-release/public-v2 branch. This change may have to find its way back to dev/emc, because the scenario to initialize regional runs using GFDL MP from RAP/HRRR data is a quite likely.

@bensonr
Copy link
Contributor

bensonr commented Dec 3, 2020

@climbfuji - do you know when and what the last PR is expected to be?

@climbfuji
Copy link
Author

I'd love to know ... we are seeing b4b differences when changing the MPI decomposition in regional runs, while in global runs the same set of physics gives b4b identical results when changing the MPI decomposition.

I am not sure yet where the problem is, it could be in the regional init code in the dycore, but it could also be in fv3atm or in the physics (although the latter is unlikely, because the physics are column based, but who knows). What I do know is that the code freeze is around mid/end of January, though.

@climbfuji
Copy link
Author

This PR is ready to merge, all regression tests passed (see ufs-community/ufs-weather-model#313).

@bensonr bensonr self-requested a review December 3, 2020 21:01
@bensonr bensonr merged commit 3930218 into NOAA-GFDL:ufs-release/public-v2 Dec 3, 2020
@climbfuji
Copy link
Author

Thanks, @bensonr !

DusanJovic-NOAA pushed a commit to NOAA-EMC/GFDL_atmos_cubed_sphere that referenced this pull request Jan 6, 2021
…can be coldstarted from RAP/HRRR input data (#49)

This PR is a cherry-pick of commit 48ea719 that went into the ufs-release/public-v2 branch of the authoritative (NOAA-GFDL) repository. See NOAA-GFDL#62 for more information.
climbfuji pushed a commit to climbfuji/GFDL_atmos_cubed_sphere that referenced this pull request Apr 24, 2024
GitFlow: Merge geos/develop into geos/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants