Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to build EnKF for FV3reg #7

Merged
merged 4 commits into from
Nov 10, 2021

Conversation

chunhuazhou
Copy link

Changes to build EnKF for FV3reg
Two files are changed
modified: CMakeLists.txt
modified: ush/build.comgsi

@chunhuazhou
Copy link
Author

I removed the option for building gsd_cloudanalysis_arw - do we still need it?

Copy link
Collaborator

@guoqing-noaa guoqing-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are still some guys who need to build enkf_wrf.x for some experiments. I would suggest to add a second command line option such as "fv3enkf" so that ufs-srweather-app will build enkf_fv3reg.x but running build.comgsi without this option will build enkf_wrf.x

@chunhuazhou
Copy link
Author

I think there are still some guys who need to build enkf_wrf.x for some experiments. I would suggest to add a second command line option such as "fv3enkf" so that ufs-srweather-app will build enkf_fv3reg.x but running build.comgsi without this option will build enkf_wrf.x

Thank you for the suggestion! Just added "ENKF_TYPE=FV3reg" to devbuild.sh (a PR for the app) and this option to build.comgsi. Please let me know what you think.

@chunhuazhou
Copy link
Author

@guoqing-noaa @hu5970 I have tested the changes and gsi.x and enkf_fv3reg.x both worked fine. If there is no further comments or objections, I will merge the changes. Thanks!

@guoqing-noaa
Copy link
Collaborator

I would prefer using a command line parameter instead of an environmental variable. Later today I will make a PR to your branch to let you decide the final solution and elaborate more on this. Thanks!

@chunhuazhou
Copy link
Author

I would prefer using a command line parameter instead of an environmental variable. Later today I will make a PR to your branch to let you decide the final solution and elaborate more on this. Thanks!
That would be great! Thank you!

guoqing-noaa and others added 2 commits November 10, 2021 15:30
…sses.

change how to assign dir_root so that users can run build.comgsi under ush/
@chunhuazhou chunhuazhou merged commit 2c8edc5 into NOAA-GSL:feature/rrfs Nov 10, 2021
@chunhuazhou chunhuazhou deleted the Add_EnKF_build branch November 10, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants