-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to build EnKF for FV3reg #7
Changes to build EnKF for FV3reg #7
Conversation
I removed the option for building gsd_cloudanalysis_arw - do we still need it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are still some guys who need to build enkf_wrf.x for some experiments. I would suggest to add a second command line option such as "fv3enkf" so that ufs-srweather-app will build enkf_fv3reg.x but running build.comgsi without this option will build enkf_wrf.x
Thank you for the suggestion! Just added "ENKF_TYPE=FV3reg" to devbuild.sh (a PR for the app) and this option to build.comgsi. Please let me know what you think. |
@guoqing-noaa @hu5970 I have tested the changes and gsi.x and enkf_fv3reg.x both worked fine. If there is no further comments or objections, I will merge the changes. Thanks! |
I would prefer using a command line parameter instead of an environmental variable. Later today I will make a PR to your branch to let you decide the final solution and elaborate more on this. Thanks! |
|
…sses. change how to assign dir_root so that users can run build.comgsi under ush/
enhance build.comgsi
Changes to build EnKF for FV3reg
Two files are changed
modified: CMakeLists.txt
modified: ush/build.comgsi