Add IFI #36
Merged
Add IFI #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Turn on GSD cloud ceiling calculation for RRFS dev. * Updates to UPP for RRFS applications (NOAA-GSL#3) * Updates to UPP for RRFS applications: 1) Adding a RRFS-specific .xml control file and a corresponding .txt flat file. Note that script changes (pending) are needed to leverage the new flat file. However, this code will work in current real-time configurations. 2) Adding GSL experimental ceiling diagnostics, GSL visibility diagnostic, and GSL sea-level pressure reduction (MAPS). Also adding TKE and aerosol number concentrations. 3) Code clean-up for ceiling-related diagnostics; added comments, etc. 4) Removing several non-needed variables, originally inherited from FV3-SAR community configuration. * Updating UPP control files to specify GRIB2 generating center as "noaa_fsl_boulder" and the generating process as "hrrr". The "hrrr" specification is temporary, and will eventually be switched to "rrfs" once required changes to the "NCEPLIBS-g2tmpl" library are available. (NOAA-GSL#4) * Fix some out-of-bounds reads that caused the RRFS UPP to crash. (NOAA-GSL#5) * Adding README file (NOAA-GSL#7) * Adding README file to describe process of making a "flat" file. * Updates to README to improve explanation of input/output files. * Code to read in Flash Flood Guidance (FFG) and Average Recurrence Interval (ARI) precipitation datasets for comparison with model QPF within UPP. * Fixed a syntax error in SURFCE.f * Getting rid of GRIB1 output option to be consistent with rest of code. * Changing field numbers to avoid conflict with existing RRFS-dev1 fields. * Putting exceedance grids in flat files for testing in RRFS UPP. * Corrected the 1h and run total precip names for calculating exceedances in SURFCE.f * Bug fix in SURFCE.f if statements. * Removing changes to RQSTFLD.F since GRIB1 is no longer used in UPP. * Merging NOAA-GSL development on top of NOAA-EMC UPP for testing. * Correcting minor typos in SURFCE.f to allow testing. * Update code based on testing with RRFS cases. * Update part of the code based on current EMC develop branch for comparing the test results with the merged version.(NOAA-GSL#9) * Fixed several bugs in the code. * Modifications to SURFCE.f to check for existence of FFG files. * Bug fixes for FFG file existence check, and changes to handle rotated lat-lon grid interpolation for FFG * Bug fixes for FFG existence checks in SURFCE.f * Another bug fix for SURFCE.f * Updating XML and flat txt files to include a 65th vertical level to be consistent with updated FV3LAM model with higher model top. (NOAA-GSL#13) * Code cleanup for QPF - FFG comparison. Comparison put into subroutine. * Cleanup of SURFCE.f; moving the FFG comparisons into a subroutine. * Final cleanup of exceedance code for QPF vs FFG. * Removing some commented out variable declarations. * Additional cleanup recommended by Ming: we really only need two exceedance variables; one for 1h FFG and one for run total FFG exceedances. * Further cleanup of FFG code, simplifying to two fields (1h acc and run total acc) * Adding ARI comparison fields for 2y, 5y, 10y, and 100y ARIs. * Changes to output 9 soil levels from FV3LAM if we are running 9 level RUC LSM. * Adding flat txt file for UPP. * Commenting out the use of the ARI exceedances for now. We can switch them on later. * Bug fix in INITPOST_NETCDF.f : need to use both ncid2d and ncid3d in this subroutine! * Adding NOAA-GSL code changes on top of latest NOAA-EMC UPP. * Couple of bug fixes in NOAA-EMC code. Bugs were leading to PRMSL and -10C REFD being all zeroes. * Cleaning up code to get rid of unnecessary differences from EMC. * Putting all new GSL variables into EMC's unified post_avblflds.xml. Note that EMC's unified post_avblflds.xml does not validate using the avblflds Schema. * Updating postconfig-NT.txt file for GSL RRFS based on merged post_avblflds.xml file. * Adding RRFS control files to makefile. * Changing back scale for WEASD_ON_SURFACE to previous default, thanks to suggestion from Wen Meng. * Reverting name of cldfra based on feedback from Eric Aligo. * Reverting changes in fv3lam_post_avblflds.xml since GSL new variables are now included in post_avblflds.xml * Changing experimental ceiling level type from "ceiling" to "cloud_ceilng" * Updating 3drtma_postcntrl.xml with revised name for GSD_EXP_CEILING. This also affects postxconfig-NT-3drtma.txt. postxconfig-NT-fv3lam_rrfs.txt also changed due to changes in post_avblflds.xml * Introducing if statement for call of NGMSLP, to avoid calling unless it is needed. Co-authored-by: Ming.Hu <Ming.Hu@noaa.gov> Co-authored-by: Christina Holt <56881914+christinaholtNOAA@users.noreply.github.com> Co-authored-by: Christina Holt <Christina.Holt@noaa.gov> Co-authored-by: Jaymes Kenyon <jaymes.kenyon@noaa.gov> Co-authored-by: Samuel Trahan (NOAA contractor) <39415369+SamuelTrahanNOAA@users.noreply.github.com>
Doxygen for CALDWP.f
* Doxygen for CALDRG.f * Delete CALDWP.f * Revert "Delete CALDWP.f" This reverts commit 575cd93.
* Add gtg code as submodule. * Remove manage_externals. * Sync with the changes from GFSV16. * Add change logs for POSTGRB2TBL default setting.
* add option to build with GTG code or stubs * make IP optional depending on GTG option. * GTG code depends on a file that only resides in the gtg repo * fix a big boo-boo * move sorc/post_gtg.fd to sorc/ncep_post.fd/post_gtg.fd and update build path to GTG * correct the name of the submodule. fix mixed indents * move map_routines.F90 into the GTG src list
* Add command line arguments in compile_upp.sh for options, e.g. building with gtg code, building with wrfio stub code, turning on cmake verbose. * Remove legacy GNU make capability.
* Remove read interfaces INITPOST_GFS_NEMS, INITPOST_GFS_NEMS_MPIIO and INITPOST_GFS_NMM. * Change linking order for w3nco and nemsio * Remove INITPOST_GFS_NETCDF * Remove INITPOST_GFS_NEMS.f, INITPOST_GFS_NETCDF.f, INITPOST_NEMS.f, INITPOST_NEMS_MPIIO.f from UPP code. * Fix build failture. * Clean up legacy makefile * Clean up another two makefiles * Add back INITPOST_GFS_NETCDF
* Add changes for WCOSS2 Acorn. * Add changes for Dogwood. * Add changes for WCOSS2. * Change modulefile on wcoss2 in LUA format based on Kate's comments. * Add machine recognition for cactus and WCOSS1 P3.5 based on Eric's comments
…s sending the wrong CAPE, CIN, and APCP
* modified: scripts/exgdas_atmos_nceppost.sh * modified: scripts/exgfs_atmos_nceppost.sh
…C#441) * Changes for parallel netcdf read for regional FV3 interface * Clean up debugging code * Replace small with the one defined in params_mod based on Huiya's comments.
…stic output. All results match standalone program.
* Doxygen for CALDRG.f * This is part of Issue NOAA-EMC#392 Fixes the doxygen warnings in CALGUST.f Please review this subroutine. Thank you.
* Modify CALUPDHEL.f for restricting undefined grids in computation. * Update VERSION to 10.0.12.
Co-authored-by: Tracy <tracy.hertneky@noaa.gov>
* Further refinement to the tables and logs. * Further refinement to the tables and logs. (NOAA-EMC#455)
Fixes the doxygen warnings in CALHEL.f CALHEL2.f CALHEL3.f Please review this subroutine. Thank you.
* Unify the interfaces for reading FV3 outputs in netcdf. * Remove interface INITPOST_GFS_NETCDF_PARA. * Remove INITPOST_GFS_NETCDF.f. * Remove the capability of serial netcdf reading FV3 outputs. * Correct reading rswinc. * Remove duplication in CLDRAD.f. * Remove duplicated avgalbedo reading * Add changes for reading pwat from model. * Clean up commented out code * Clean up duplicated lines
…e modulefiles for gnu and intel (NOAA-EMC#468) * Add cheyenne modulefile * Intel 19 --> 2021 * Add ability to specify compiler; move all existing modulefiles to ${name}_intel since they are all for intel compilers; add "cheyenne_gnu" modulefile * Revert move of intel modulefiles; now the implicit default for a modulefile is intel, only gnu and other compilers will have the compiler name appended to the modulefile * Allow for lua modulefiles with ".lua" appended
* Eliminate out-of-bounds access in CALCAPE2 with extreme atmospheric conditions * Author note update for CALCAPE2
…OAA-EMC#559) * Fix out-of-bounds accesses and modernize some line-number do loops * add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to top of develop, adds in-flight icing forecast products, and fixes an out-of-bounds bug in CALCAPE2.
For a full description, see these PRs:
NOAA-EMC#536
NOAA-EMC#555