Merge gsl/develop to RRFS_dev #137
Conversation
…onsistency checking
Add support for Stochastically Perturbed Parameterizations (SPP) in FV3
Merge NCAR main into gsl/develop
…no shallow scheme
Remove GF Consistency Check & Add SDFs - V2
Remove Dom, add new code manager Christina and various developers.
SamuelTrahanNOAA
requested review from
hu5970,
joeolson42,
hannahcbarnes and
tanyasmirnova
| @@ -7,7 +7,7 @@ module cu_gf_driver | |||
| ! DH* TODO: replace constants with arguments to cu_gf_driver_run | |||
| !use physcons , g => con_g, cp => con_cp, xlv => con_hvap, r_v => con_rv | |||
| use machine , only: kind_phys | |||
| use cu_gf_deep, only: cu_gf_deep_run,neg_check,fct1d3 | |||
| use cu_gf_deep, only: cu_gf_deep_run,neg_check,autoconv,aeroevap,fct1d3 | |||
There was a problem hiding this comment.
autoconv and aeroevap should no longer be in this use statement
There was a problem hiding this comment.
I believe this was a workaround for a compiler issue. The compiler wanted some extra things in the scope that it shouldn't need.
There was a problem hiding this comment.
Strange, we did not run into that issue before. But I guess it is not a big deal.
There was a problem hiding this comment.
Remember that the community repository is more widely tested than our branches. There are many compiler versions on many platforms, each of which has its own eccentricities.
| else | ||
| do i=1,im | ||
| if (icy(i)) then | ||
| if (kdt == 1 .or. (.not. cplflx .or. lakefrac(i) > zero)) then |
There was a problem hiding this comment.
@SamuelTrahanNOAA A PR#131 has to be merged into this code. This line should be:
if ((kdt == 1.and. lsm_cold_start) .or. (.not. cplflx .or. lsm==lsm_ruc .or. lakefrac(i) > zero)) then
There was a problem hiding this comment.
That PR can go in next.
There was a problem hiding this comment.
The code change you (@tanyasmirnova) request does not belong in this PR because the sole purpose of this PR is to merge gsl/develop into RRFS_dev. All #131 changes need to be in a separate PR.
Replaces PR #136