From d44df133628bc948fa66f859deafc95246e6bf5d Mon Sep 17 00:00:00 2001 From: Eric Ringold Date: Fri, 22 Dec 2023 12:09:34 -0700 Subject: [PATCH 1/2] update Rfilm_in to match Energyplus --- .../resources/os_lib_model_generation.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/measures/create_typical_building_from_model/resources/os_lib_model_generation.rb b/resources/measures/create_typical_building_from_model/resources/os_lib_model_generation.rb index 082649e95..63cfe06c7 100644 --- a/resources/measures/create_typical_building_from_model/resources/os_lib_model_generation.rb +++ b/resources/measures/create_typical_building_from_model/resources/os_lib_model_generation.rb @@ -2697,8 +2697,8 @@ def typical_building_from_model(model, runner, user_arguments) # adjust F factor constructions to avoid simulation errors model.getFFactorGroundFloorConstructions.each do |cons| - # Rfilm_in = 0.125, Rfilm_out = 0.03, Rcons = 0.15/1.95 - if cons.area <= (0.125 + 0.03 + 0.15/1.95) * cons.perimeterExposed * cons.fFactor + # Rfilm_in = 0.135, Rfilm_out = 0.03, Rcons = 0.15/1.95 + if cons.area <= (0.135 + 0.03 + 0.15/1.95) * cons.perimeterExposed * cons.fFactor # set minimum Rfic to > 1e-3 new_area = 0.233 * cons.perimeterExposed * cons.fFactor runner.registerInfo("F-factor fictitious resistance for #{cons.name.get} with Area=#{cons.area.round(2)}, Exposed Perimeter=#{cons.perimeterExposed.round(2)}, and F-factor=#{cons.fFactor.round(2)} will result in a negative value and a failed simulation. Construction area is adjusted to be #{new_area.round(2)}.") From e7c45f44add298e910a07e7a934038dc7dc7c73e Mon Sep 17 00:00:00 2001 From: Matthew Dahlhausen Date: Tue, 2 Jan 2024 08:25:52 -0700 Subject: [PATCH 2/2] Update measure.xml --- .../measures/create_typical_building_from_model/measure.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/resources/measures/create_typical_building_from_model/measure.xml b/resources/measures/create_typical_building_from_model/measure.xml index 7183b6d41..c7b7be039 100644 --- a/resources/measures/create_typical_building_from_model/measure.xml +++ b/resources/measures/create_typical_building_from_model/measure.xml @@ -3,8 +3,8 @@ 3.1 create_typical_building_from_model 339a2e3a-273c-4494-bb50-bfe586a0647c - d4d8e1ca-a5db-47e0-aae1-f98dad728eb8 - 2023-10-16T20:24:52Z + e0d7a67d-835a-43a5-9698-36b20ceda38f + 2024-01-02T15:25:32Z EE13F09F CreateTypicalBuildingFromModel Create Typical Building from Model @@ -1475,7 +1475,7 @@ os_lib_model_generation.rb rb resource - 7AA832CC + 3097D1DE GenericGbxml.osm