From 318d7721c671847eb77d978beff340b0a1a30831 Mon Sep 17 00:00:00 2001
From: Julien Marrec <julien.marrec@gmail.com>
Date: Tue, 14 Jan 2025 17:52:26 +0100
Subject: [PATCH] FIx #5339 - Fixup Idd units m3/s -> gal/min

Temporarily changed the ruby script

```diff
diff --git a/developer/ruby/FindAndAddMissingIPUnits.rb b/developer/ruby/FindAndAddMissingIPUnits.rb
index ba4d846c89..0459f3bd1c 100644
--- a/developer/ruby/FindAndAddMissingIPUnits.rb
+++ b/developer/ruby/FindAndAddMissingIPUnits.rb
@@ -46,8 +46,8 @@ iddWrapper = oIddFile.get
 def apply_water_flow_rate(iddWrapper)

   puts "Looking for missing gal/min in Water Flow Rate fields"
-  include_words = ['water', 'flow', 'rate']
-  exclude_words = ['ratio', 'fraction', 'curve', 'length', 'mass']
+  include_words = ['flow', 'rate']
+  exclude_words = ['air', 'ratio', 'fraction', 'curve', 'length', 'mass', ' per ', 'schedule', 'method']

   n_missing = 0

```
---
 resources/model/OpenStudio.idd | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/resources/model/OpenStudio.idd b/resources/model/OpenStudio.idd
index 29f7d7f557..ddf181bb8e 100644
--- a/resources/model/OpenStudio.idd
+++ b/resources/model/OpenStudio.idd
@@ -9230,7 +9230,8 @@ OS:Refrigeration:SecondarySystem,
   N3,   \field Evaporator Flow Rate for Secondary Fluid
         \type real
         \minimum 0.0
-        \units M3/s
+        \units m3/s
+        \ip-units gal/min
         \note For "FluidAlwaysLiquid", at least one of the two, Evaporator Capacity OR
         \note    Evaporator Flow Rate for Secondary Fluid, is required.
         \note For "FluidPhaseChange" loops, this input is not used. (see PhaseChange Circulating
@@ -9265,7 +9266,8 @@ OS:Refrigeration:SecondarySystem,
   N8,   \field Total Pump Flow Rate
         \type real
         \minimum 0.0
-        \units M3/s
+        \units m3/s
+        \ip-units gal/min
         \note For "FluidAlwaysLiquid",if not input, Evaporator Flow Rate for Secondary Fluid
         \note       will be used.
         \note For "FluidPhaseChange", if not input, this will be calculated using the
@@ -14552,6 +14554,7 @@ OS:HeatPump:AirToWater:FuelFired:Heating,
        \autosizable
        \minimum> 0
        \units m3/s
+       \ip-units gal/min
        \required-field
        \note Design Flow Rate in m3/s (autosizable)
    N4, \field Design Supply Temperature
@@ -14737,6 +14740,7 @@ OS:HeatPump:AirToWater:FuelFired:Cooling,
        \autosizable
        \minimum> 0
        \units m3/s
+       \ip-units gal/min
        \required-field
        \note Design Flow Rate in m3/s (autosizable)
    N4, \field Design Supply Temperature
@@ -17233,6 +17237,7 @@ OS:GroundHeatExchanger:HorizontalTrench,
         \required-field
         \type real
         \units m3/s
+        \ip-units gal/min
         \minimum> 0
    N2 , \field Trench Length in Pipe Axial Direction
         \note This is the total pipe axial length of the heat exchanger
@@ -31334,6 +31339,7 @@ OS:WaterHeater:Mixed,
        \note Not yet implemented
        \type real
        \units m3/s
+       \ip-units gal/min
        \minimum 0.0
        \default 0.0
   N7 , \field Heater Ignition Delay
@@ -33921,6 +33927,7 @@ OS:SolarCollectorPerformance:FlatPlate,
        \type real
        \minimum> 0
        \units m3/s
+       \ip-units gal/min
   A4 , \field Test Correlation Type
        \required-field
        \type choice
@@ -33979,6 +33986,7 @@ OS:SolarCollector:FlatPlate:Water,
        \type real
        \minimum> 0
        \units m3/s
+       \ip-units gal/min
 
 OS:SolarCollectorPerformance:IntegralCollectorStorage,
        \memo Thermal and optical performance parameters for a single glazed solar collector with
@@ -34161,6 +34169,7 @@ OS:SolarCollector:IntegralCollectorStorage,
        \type real
        \minimum> 0
        \units m3/s
+       \ip-units gal/min
 
 OS:SolarCollectorPerformance:PhotovoltaicThermal:Simple,
        \memo Thermal performance parameters for a hybrid photovoltaic-thermal (PVT) solar collector.