From 474766603427f8ef2f774b18d19f3769cc3ff9f7 Mon Sep 17 00:00:00 2001 From: Weili Xu Date: Fri, 1 Sep 2023 08:54:44 -0700 Subject: [PATCH 1/2] Include fenestration types_to_modify to apply correct PRM construction to exterior fenestration surfaces --- .../standards/ashrae_90_1_prm/ashrae_90_1_prm.Model.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/openstudio-standards/standards/ashrae_90_1_prm/ashrae_90_1_prm.Model.rb b/lib/openstudio-standards/standards/ashrae_90_1_prm/ashrae_90_1_prm.Model.rb index 4261ade77b..c510df5131 100644 --- a/lib/openstudio-standards/standards/ashrae_90_1_prm/ashrae_90_1_prm.Model.rb +++ b/lib/openstudio-standards/standards/ashrae_90_1_prm/ashrae_90_1_prm.Model.rb @@ -579,6 +579,8 @@ def model_apply_prm_construction_types(model) types_to_modify << ['Outdoors', 'ExteriorWall', 'SteelFramed'] types_to_modify << ['Outdoors', 'ExteriorRoof', 'IEAD'] types_to_modify << ['Outdoors', 'ExteriorFloor', 'SteelFramed'] + types_to_modify << ['Outdoors', 'ExteriorWindow', 'Any Vertical Glazing'] + types_to_modify << ['Outdoors', 'GlassDoor', 'Any Vertical Glazing'] types_to_modify << ['Ground', 'GroundContactFloor', 'Unheated'] types_to_modify << ['Ground', 'GroundContactWall', 'Mass'] From 651563883b3efce96ebc0b9f3db15f6c78f658b8 Mon Sep 17 00:00:00 2001 From: Weili Xu Date: Sat, 2 Sep 2023 09:24:35 -0700 Subject: [PATCH 2/2] add exterior doors to fix the wwr error. --- .../standards/ashrae_90_1_prm/ashrae_90_1_prm.Model.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/openstudio-standards/standards/ashrae_90_1_prm/ashrae_90_1_prm.Model.rb b/lib/openstudio-standards/standards/ashrae_90_1_prm/ashrae_90_1_prm.Model.rb index c510df5131..b0be7b5a2c 100644 --- a/lib/openstudio-standards/standards/ashrae_90_1_prm/ashrae_90_1_prm.Model.rb +++ b/lib/openstudio-standards/standards/ashrae_90_1_prm/ashrae_90_1_prm.Model.rb @@ -581,6 +581,8 @@ def model_apply_prm_construction_types(model) types_to_modify << ['Outdoors', 'ExteriorFloor', 'SteelFramed'] types_to_modify << ['Outdoors', 'ExteriorWindow', 'Any Vertical Glazing'] types_to_modify << ['Outdoors', 'GlassDoor', 'Any Vertical Glazing'] + types_to_modify << ['Outdoors', 'ExteriorDoor', 'NonSwinging'] + types_to_modify << ['Outdoors', 'ExteriorDoor', 'Swinging'] types_to_modify << ['Ground', 'GroundContactFloor', 'Unheated'] types_to_modify << ['Ground', 'GroundContactWall', 'Mass']