Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 提高可維護性、移除多餘的括弧 #58

Merged
merged 2 commits into from
Dec 25, 2023
Merged

refactor: 提高可維護性、移除多餘的括弧 #58

merged 2 commits into from
Dec 25, 2023

Conversation

iwtba4188
Copy link
Contributor

@iwtba4188 iwtba4188 commented Dec 23, 2023 •
edited
Loading

  • 雖然把重複的地方都拉到 constant 裡面，但我不是很確定有沒有比以前好，可維護性感覺有變高，但可讀性不敢說

@iwtba4188 iwtba4188 added the refactoring Changes in the way the code works internally without changing the output produced. label Dec 23, 2023
@iwtba4188 iwtba4188 requested a review from l7wei December 23, 2023 13:15
@iwtba4188 iwtba4188 mentioned this pull request Dec 23, 2023
Open
@l7wei l7wei merged commit 0fcff61 into NTHU-SA:main Dec 25, 2023
2 checks passed
iwtba4188 added a commit to iwtba4188/NTHU-Data-API that referenced this pull request Dec 25, 2023
@iwtba4188
refactor: 提高可維護性、移除多餘的括弧 (NTHU-SA#58)
49aa8cf 
* refactor: 將重複性高的 Path/Query 移到 constant

* refactor(buses): remove redundant parentheses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l7wei l7wei l7wei approved these changes

Assignees
No one assigned
Labels
refactoring Changes in the way the code works internally without changing the output produced.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iwtba4188 @l7wei