Change type() to isinstance() to check object types

Author: tgasser-nv

nemoguardrails/actions/llm/generation.py

@@ -156,7 +156,7 @@ def _extract_user_message_example(self, flow: Flow) -> None:
                 # The SpecOp.spec type is Union[Spec, dict]. Convert Dict to Spec if it's provided
                 match_spec: Spec = (
                     spec_op.spec
-                    if type(spec_op.spec) == Spec
+                    if isinstance(spec_op.spec, Spec)
                     else Spec(**cast(Dict, spec_op.spec))
                 )
 
@@ -179,7 +179,7 @@ def _extract_user_message_example(self, flow: Flow) -> None:
                 # which isn't in the Spec definition
                 await_spec_dict: Dict[str, Any] = (
                     asdict(spec_op.spec)
-                    if type(spec_op.spec) == Spec
+                    if isinstance(spec_op.spec, Spec)
                     else cast(Dict, spec_op.spec)
                 )
 
@@ -213,15 +213,15 @@ def _extract_bot_message_example(self, flow: Flow):
 
         el = flow.elements[1]
 
-        if type(el) != SpecOp:
+        if not isinstance(el, SpecOp):
             return
 
         spec_op: SpecOp = cast(SpecOp, el)
         spec: Dict[str, Any] = (
             asdict(
                 spec_op.spec
-            )  # TODO! Refactor thiss function as it's duplicated in many places
-            if type(spec_op.spec) == Spec
+            )  # TODO! Refactor this function as it's duplicated in many places
+            if isinstance(spec_op.spec, Spec)
             else cast(Dict, spec_op.spec)
         )
 
@@ -241,7 +241,7 @@ def _process_flows(self):
         """Process the provided flows to extract the user utterance examples."""
         # Flows can be either Flow or Dict. Convert them all to Flow for following code
         flows: List[Flow] = [
-            cast(Flow, flow) if type(flow) == Flow else Flow(**cast(Dict, flow))
+            cast(Flow, flow) if isinstance(flow, Flow) else Flow(**cast(Dict, flow))
             for flow in self.config.flows
         ]
 

nemoguardrails/actions/v2_x/generation.py

@@ -217,7 +217,7 @@ async def _collect_user_intent_and_examples(
         heads = find_all_active_event_matchers(state)
         for head in heads:
             el = get_element_from_head(state, head)
-            element = el if type(el) == SpecOp else SpecOp(**cast(Dict, el))
+            element = el if isinstance(el, SpecOp) else SpecOp(**cast(Dict, el))
             flow_state = state.flow_states[head.flow_state_uid]
             event = get_event_from_element(state, flow_state, element)
             if (