Skip to content

Conversation

@SSK-14
Copy link
Contributor

@SSK-14 SSK-14 commented Oct 13, 2024

Description

This PR contains a very small documentation change in the CONTRIBUTING.md file. The folder name in the command after cloning the repository was incorrect and facing error with pre-commit setup, and I have fixed it to reflect the correct name and command.

Related Issue(s)

While running this:

python -m pre-commit install

/Users/.../OSS/NeMo-Guardrails/venv/bin/python: No module named pre-commit

Checklist

  • I've read the CONTRIBUTING guidelines.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • @mentions of the person or team responsible for reviewing proposed changes.

@SSK-14 SSK-14 changed the title Doc: Fix incorrect folder name in CONTRIBUTING.md Doc: Fix incorrect folder name & pre-commit setup in CONTRIBUTING.md Oct 14, 2024
@Pouyanpi
Copy link
Collaborator

Thank you @SSK-14 for your PR!

@Pouyanpi Pouyanpi self-requested a review October 15, 2024 07:36
Copy link
Collaborator

@Pouyanpi Pouyanpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@Pouyanpi Pouyanpi mentioned this pull request Oct 15, 2024
4 tasks
@Pouyanpi Pouyanpi merged commit 5a48f7c into NVIDIA-NeMo:develop Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants