Skip to content

Feature: migrate to poetry #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Dec 2, 2024
Merged

Feature: migrate to poetry #826

merged 27 commits into from
Dec 2, 2024

Conversation

@Pouyanpi
Copy link
Collaborator

@Pouyanpi Pouyanpi commented Oct 26, 2024 •
edited
Loading

Description

Migrate to Poetry

Related Issue(s)

Workflow State

  • PR tests: pass
  • Full tests: pass
  • Build and Test Python Wheel: pass
  • Test Docker image: fail (requires auth - set to workflow dispatch)
  • Settings -> branches > branch protection rules

Checklist

  • I've read the CONTRIBUTING guidelines.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • @mentions of the person or team responsible for reviewing proposed changes.

@Pouyanpi Pouyanpi marked this pull request as draft October 26, 2024 10:57
@Pouyanpi Pouyanpi changed the title [!draf] Feature: migrate to poetry [!draft] Feature: migrate to poetry Oct 26, 2024
@Pouyanpi Pouyanpi force-pushed the feature/poetry branch 8 times, most recently from 7b4678f to 1536ddb Compare October 27, 2024 11:12
@Pouyanpi Pouyanpi added dependencies Pull requests that update a dependency file CI labels Oct 27, 2024
@Pouyanpi Pouyanpi force-pushed the feature/poetry branch 17 times, most recently from fd21532 to c6375e7 Compare October 29, 2024 19:29
@Pouyanpi Pouyanpi force-pushed the feature/poetry branch 3 times, most recently from f0653cd to b613696 Compare November 19, 2024 12:11
@Pouyanpi
ci: add GitHub Actions workflow for building and testing wheel
2a09bd0 
chore(workflows): remove comments
@Pouyanpi
ci: add workflow to test Docker image (not working)
b7a30a8
@Pouyanpi
refactor: rename test classes to supress pytest warning
284102d
@Pouyanpi
fix: use temp directory for .railsignore in tests
fb7eb9b 
This commit updates the `test_railsignore.py` to use the system's
temporary directory for the `.railsignore` file. This change addresses
issues with tests on Windows OS by ensuring the `.railsignore` file is
created in a writable location
@Pouyanpi
chore: update issue templates with triage labels
ba1229d
@Pouyanpi
chore: add documentation issue template
b625797
@Pouyanpi
docs: update CONTRIBUTING.md for Poetry migration
2957146
@Pouyanpi
feat(workflows): add lock closed threads workflow
f70b5ec
@Pouyanpi
feat(workflows): add test-published-dist workflow
7183b31 
This workflow tests the published distribution of the package from PyPI
daily. It sets up Python environments for versions 3.9, 3.10, and 3.11,
installs the package, starts the server, and checks its status. This
ensures the published package works as expected.
@Pouyanpi
refactor: consolidate dependencies in pyproject.toml
c8cc382
@Pouyanpi
feat(ci): update cron schedule to 11:00 PM UTC daily
b452b77
@Pouyanpi
chore(tox): add instructions for using pyenv with tox
0ff66b2
@Pouyanpi
fix(ci): remove image from registry if tests fail
28444ea
cparisien
cparisien approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@cparisien cparisien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine with me but I know very little about poetry. I reviewed this for glaring things like accidental local paths.

@cparisien
Copy link
Collaborator

cparisien commented Nov 28, 2024

Still need to fix the failing windows tests though:
FAILED tests/v2_x/test_attention_library.py::test_1_3 - AssertionError: Expected got inattentive and received got attentive

@sklinglernv
Copy link
Collaborator

sklinglernv commented Nov 29, 2024

I can repro the failing test on Windows, will look into fixing it

@sklinglernv
Copy link
Collaborator

sklinglernv commented Nov 29, 2024

Still need to fix the failing windows tests though: FAILED tests/v2_x/test_attention_library.py::test_1_3 - AssertionError: Expected got inattentive and received got attentive

Should be fixed with 0be86a4

@Pouyanpi Pouyanpi marked this pull request as ready for review November 30, 2024 09:46
@Pouyanpi
Copy link
Collaborator Author

Pouyanpi commented Nov 30, 2024

Still need to fix the failing windows tests though: FAILED tests/v2_x/test_attention_library.py::test_1_3 - AssertionError: Expected got inattentive and received got attentive

Should be fixed with 0be86a4

Thank you @sklinglernv , all tests pass 👍🏻

@Pouyanpi Pouyanpi changed the title [!draft] Feature: migrate to poetry Feature: migrate to poetry Nov 30, 2024
@Pouyanpi Pouyanpi merged commit 6816c8a into develop Dec 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cparisien cparisien cparisien approved these changes

@schuellc-nvidia schuellc-nvidia Awaiting requested review from schuellc-nvidia

Assignees

@Pouyanpi Pouyanpi

Labels

CI dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Pouyanpi @cparisien @sklinglernv