Process TFRecord reader binding classes only when it is enabled #5360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
stiepan
approved these changes
Mar 7, 2024
|
CI MESSAGE: [13345998]: BUILD STARTED |
|
CI MESSAGE: [13345998]: BUILD PASSED |
jantonguirao
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: Bug fix
Description:
Only parse the code and create the TFRecord reader API bindings/classes when the feature is enabled.
Additional information:
Affected modules and functionalities:
TFRecord Python bidnings
Key points relevant for the review:
It just adds the if statement and indents the implementation.
Tests:
Should fix the custom src pattern test and work as is in the rest of DALI
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A