Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check invalid input directory in nvflare config #2295

Merged
merged 2 commits into from
Jan 20, 2024

Conversation

chesterxgchen
Copy link
Collaborator

Fixes # .

check input directory in nvflare config

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanTingHsieh
Copy link
Collaborator

/build

@chesterxgchen chesterxgchen merged commit af027a0 into NVIDIA:main Jan 20, 2024
16 checks passed
@chesterxgchen chesterxgchen deleted the job_template branch January 20, 2024 01:09
chesterxgchen added a commit to chesterxgchen/NVFlare that referenced this pull request Jan 24, 2024
* check invalid input directory

* check invalid input directory

add doc string

add doc string

rename receive_messages() to receive_message()

change doc str to google doc string style
chesterxgchen added a commit to chesterxgchen/NVFlare that referenced this pull request Jan 24, 2024
* check invalid input directory

* check invalid input directory

add doc string

add doc string

rename receive_messages() to receive_message()

change doc str to google doc string style

rebase and formats
chesterxgchen added a commit to chesterxgchen/NVFlare that referenced this pull request Jan 27, 2024
* check invalid input directory

* check invalid input directory

add doc string

add doc string

rename receive_messages() to receive_message()

change doc str to google doc string style

rebase and formats
chesterxgchen added a commit to chesterxgchen/NVFlare that referenced this pull request Feb 5, 2024
* check invalid input directory

* check invalid input directory

add doc string

add doc string

rename receive_messages() to receive_message()

change doc str to google doc string style

rebase and formats
YuanTingHsieh pushed a commit that referenced this pull request Feb 5, 2024
* add message bus

address PR comments
formatting

* Check invalid input directory in nvflare config (#2295)

* check invalid input directory

* check invalid input directory

add doc string

add doc string

rename receive_messages() to receive_message()

change doc str to google doc string style

rebase and formats

* remove space

* restore space

* Address PR comments
1) remove data store scope/topic
2) add pub_sub interface and let databus implements the inferface
3) remove function_utils.py and unit tests for another PR

* Address PR comments
1) remove data store scope/topic
2) add pub_sub interface and let databus implements the inferface
3) remove function_utils.py and unit tests for another PR

* reduce lock scope

* make sure the publish in parallel instead of sequential

* rename send_data/receive_data() to put_data()/get_data()

---------

Co-authored-by: Sean Yang <seany314@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants