-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check invalid input directory in nvflare config #2295
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuanTingHsieh
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/build |
chesterxgchen
added a commit
to chesterxgchen/NVFlare
that referenced
this pull request
Jan 24, 2024
* check invalid input directory * check invalid input directory add doc string add doc string rename receive_messages() to receive_message() change doc str to google doc string style
chesterxgchen
added a commit
to chesterxgchen/NVFlare
that referenced
this pull request
Jan 24, 2024
* check invalid input directory * check invalid input directory add doc string add doc string rename receive_messages() to receive_message() change doc str to google doc string style rebase and formats
chesterxgchen
added a commit
to chesterxgchen/NVFlare
that referenced
this pull request
Jan 27, 2024
* check invalid input directory * check invalid input directory add doc string add doc string rename receive_messages() to receive_message() change doc str to google doc string style rebase and formats
chesterxgchen
added a commit
to chesterxgchen/NVFlare
that referenced
this pull request
Feb 5, 2024
* check invalid input directory * check invalid input directory add doc string add doc string rename receive_messages() to receive_message() change doc str to google doc string style rebase and formats
YuanTingHsieh
pushed a commit
that referenced
this pull request
Feb 5, 2024
* add message bus address PR comments formatting * Check invalid input directory in nvflare config (#2295) * check invalid input directory * check invalid input directory add doc string add doc string rename receive_messages() to receive_message() change doc str to google doc string style rebase and formats * remove space * restore space * Address PR comments 1) remove data store scope/topic 2) add pub_sub interface and let databus implements the inferface 3) remove function_utils.py and unit tests for another PR * Address PR comments 1) remove data store scope/topic 2) add pub_sub interface and let databus implements the inferface 3) remove function_utils.py and unit tests for another PR * reduce lock scope * make sure the publish in parallel instead of sequential * rename send_data/receive_data() to put_data()/get_data() --------- Co-authored-by: Sean Yang <seany314@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
check input directory in nvflare config
Types of changes
./runtest.sh
.