Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check invalid input directory in nvflare config #2295

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Check invalid input directory in nvflare config #2295

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1613ce
check invalid input directory
chesterxgchen Jan 19, 2024
9f661f2
check invalid input directory
chesterxgchen Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions nvflare/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,9 @@ def def_config_parser(sub_cmd):
def handle_config_cmd(args):
config_file_path, nvflare_config = get_hidden_config()

if not args.job_templates_dir or not os.path.isdir(args.job_templates_dir):
raise ValueError(f"job_templates_dir='{args.job_templates_dir}', it is not a directory")

nvflare_config = create_startup_kit_config(nvflare_config, args.startup_kit_dir)
nvflare_config = create_poc_workspace_config(nvflare_config, args.poc_workspace_dir)
nvflare_config = create_job_template_config(nvflare_config, args.job_templates_dir)
Expand Down