Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native FLARE/XGB integration #2354

Merged
merged 15 commits into from
Feb 7, 2024
Merged

Native FLARE/XGB integration #2354

merged 15 commits into from
Feb 7, 2024

Conversation

yanchengnv
Copy link
Collaborator

@yanchengnv yanchengnv commented Feb 6, 2024

Description

This is the first version of FLARE/XGB integration, where interactions between XGB clients and server are done through FLARE messages. XGB client can run either in the same process with the FL client (CJ); or in a separate local process. Similarly XGB server can run in the same process with the FL server (SJ); or in a separate local process.

A mock XGB server/client is also provided to test the overall architecture and communication performance.

This version does not have secure XGB.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

Copy link
Collaborator

@nvidianz nvidianz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanchengnv yanchengnv merged commit 912adb9 into NVIDIA:main Feb 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants