From d5d8d0a494b7dabb8351983741a24ca8b8f1d498 Mon Sep 17 00:00:00 2001 From: Zhihong Zhang Date: Thu, 5 Sep 2024 11:51:53 -0400 Subject: [PATCH 1/2] Changed split_mode to data_split_mode --- .../federated_xgboost/secure_xgboost_user_guide.rst | 3 +++ examples/advanced/xgboost_secure/README.md | 8 ++++---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/docs/user_guide/federated_xgboost/secure_xgboost_user_guide.rst b/docs/user_guide/federated_xgboost/secure_xgboost_user_guide.rst index d8058acd8c..8d76b03949 100644 --- a/docs/user_guide/federated_xgboost/secure_xgboost_user_guide.rst +++ b/docs/user_guide/federated_xgboost/secure_xgboost_user_guide.rst @@ -191,6 +191,9 @@ The following environment variables can be used to override the values in the JS export NVFLARE_XGB_PLUGIN_NAME=nvflare export NVFLARE_XGB_PLUGIN_PATH=/tmp/libnvflare.so +.. note:: + The plugin must be configured using environment variables for the simulator as it does not support resources.json. + Horizontal Secure ----------------- The plugin setup is the same as vertical secure. diff --git a/examples/advanced/xgboost_secure/README.md b/examples/advanced/xgboost_secure/README.md index c9bec56382..e20a51730c 100644 --- a/examples/advanced/xgboost_secure/README.md +++ b/examples/advanced/xgboost_secure/README.md @@ -78,22 +78,22 @@ nvflare config -jt ../../../job_templates/ # create horizontal job nvflare job create -force -w xgboost -j ./jobs/xgb_hori \ - -f config_fed_server.conf secure_training=false split_mode=0 \ + -f config_fed_server.conf secure_training=false data_split_mode=0 \ -f config_fed_client.conf folder="/tmp/nvflare/xgb_dataset/horizontal_xgb_data" # create horizontal secure job nvflare job create -force -w xgboost -j ./jobs/xgb_hori_secure \ - -f config_fed_server.conf secure_training=true split_mode=0 \ + -f config_fed_server.conf secure_training=true data_split_mode=0 \ -f config_fed_client.conf folder="/tmp/nvflare/xgb_dataset/horizontal_xgb_data" # create vertical job nvflare job create -force -w xgboost -j ./jobs/xgb_vert \ - -f config_fed_server.conf secure_training=false split_mode=1 \ + -f config_fed_server.conf secure_training=false data_split_mode=1 \ -f config_fed_client.conf folder="/tmp/nvflare/xgb_dataset/vertical_xgb_data" # create vertical secure job nvflare job create -force -w xgboost -j ./jobs/xgb_vert_secure \ - -f config_fed_server.conf secure_training=true split_mode=1 \ + -f config_fed_server.conf secure_training=true data_split_mode=1 \ -f config_fed_client.conf folder="/tmp/nvflare/xgb_dataset/vertical_xgb_data" ``` From 6fd30838a6d36abf69dad27ac9f1bc10f2078804 Mon Sep 17 00:00:00 2001 From: Zhihong Zhang Date: Thu, 5 Sep 2024 11:55:59 -0400 Subject: [PATCH 2/2] Fixed a merging error --- .../user_guide/federated_xgboost/secure_xgboost_user_guide.rst | 3 --- 1 file changed, 3 deletions(-) diff --git a/docs/user_guide/federated_xgboost/secure_xgboost_user_guide.rst b/docs/user_guide/federated_xgboost/secure_xgboost_user_guide.rst index 8d76b03949..d8058acd8c 100644 --- a/docs/user_guide/federated_xgboost/secure_xgboost_user_guide.rst +++ b/docs/user_guide/federated_xgboost/secure_xgboost_user_guide.rst @@ -191,9 +191,6 @@ The following environment variables can be used to override the values in the JS export NVFLARE_XGB_PLUGIN_NAME=nvflare export NVFLARE_XGB_PLUGIN_PATH=/tmp/libnvflare.so -.. note:: - The plugin must be configured using environment variables for the simulator as it does not support resources.json. - Horizontal Secure ----------------- The plugin setup is the same as vertical secure.