Add missing import guards for causal_conv1d and mamba_ssm dependencies #10429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nemo/collections/nlp/models/language_modeling/megatron_mamba_model.py
Dismissed
Show resolved
Hide resolved
janekl
force-pushed
the
jlasek/missing_import_guards
branch
from
0e61cda to
1d71a0a
Compare
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: janekl <janekl@users.noreply.github.com>
janekl
force-pushed
the
jlasek/missing_import_guards
branch
from
1d71a0a to
151498f
Compare
ko3n1g
pushed a commit
that referenced
this pull request
Sep 17, 2024
#10429) * Add causal_conv1d import guard Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Add mamba_ssm import guard Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Apply isort and black reformatting Signed-off-by: janekl <janekl@users.noreply.github.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: janekl <janekl@users.noreply.github.com> Co-authored-by: janekl <janekl@users.noreply.github.com> Co-authored-by: Pablo Garay <palenq@gmail.com>
gwarmstrong
pushed a commit
to gwarmstrong/NeMo
that referenced
this pull request
Sep 19, 2024
NVIDIA#10429) * Add causal_conv1d import guard Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Add mamba_ssm import guard Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Apply isort and black reformatting Signed-off-by: janekl <janekl@users.noreply.github.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: janekl <janekl@users.noreply.github.com> Co-authored-by: janekl <janekl@users.noreply.github.com> Co-authored-by: Pablo Garay <palenq@gmail.com> Signed-off-by: George Armstrong <georgea@nvidia.com>
ko3n1g
added a commit
that referenced
this pull request
Sep 26, 2024
#10429) (#10506) * Add causal_conv1d import guard * Add mamba_ssm import guard * Apply isort and black reformatting --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: janekl <janekl@users.noreply.github.com> Co-authored-by: Jan Lasek <janek.lasek@gmail.com> Co-authored-by: janekl <janekl@users.noreply.github.com> Co-authored-by: Pablo Garay <palenq@gmail.com>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
#10429) * Add causal_conv1d import guard Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Add mamba_ssm import guard Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Apply isort and black reformatting Signed-off-by: janekl <janekl@users.noreply.github.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: janekl <janekl@users.noreply.github.com> Co-authored-by: janekl <janekl@users.noreply.github.com> Co-authored-by: Pablo Garay <palenq@gmail.com>
tomlifu
pushed a commit
to tomlifu/NeMo
that referenced
this pull request
Oct 25, 2024
NVIDIA#10429) * Add causal_conv1d import guard Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Add mamba_ssm import guard Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Apply isort and black reformatting Signed-off-by: janekl <janekl@users.noreply.github.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: janekl <janekl@users.noreply.github.com> Co-authored-by: janekl <janekl@users.noreply.github.com> Co-authored-by: Pablo Garay <palenq@gmail.com> Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
tomlifu
pushed a commit
to tomlifu/NeMo
that referenced
this pull request
Oct 25, 2024
NVIDIA#10429) * Add causal_conv1d import guard Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Add mamba_ssm import guard Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Apply isort and black reformatting Signed-off-by: janekl <janekl@users.noreply.github.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: janekl <janekl@users.noreply.github.com> Co-authored-by: janekl <janekl@users.noreply.github.com> Co-authored-by: Pablo Garay <palenq@gmail.com> Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
NVIDIA#10429) * Add causal_conv1d import guard Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Add mamba_ssm import guard Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Apply isort and black reformatting Signed-off-by: janekl <janekl@users.noreply.github.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: janekl <janekl@users.noreply.github.com> Co-authored-by: janekl <janekl@users.noreply.github.com> Co-authored-by: Pablo Garay <palenq@gmail.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Currently
causal_conv1dandmamba_ssmare in fact required to use NeMo but are not included in requirements. This MR introduces the "import guard" mechanism for these two packages so that users that setup NeMo usingpip install nemo-toolkitare not immediately hit by missing dependency problems if their use case is not related to Griffin or Mamba models.Collection: NLP
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information