Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Switch to CPU only runner #11035

Merged
merged 7 commits into from
Oct 25, 2024
Merged

ci: Switch to CPU only runner #11035

merged 7 commits into from
Oct 25, 2024

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Oct 25, 2024

What does this PR do ?

To do's:

  • Rename test-cpu-runner to azure-self-hosted-cpu
  • Merge
  • Rename runner label
  • Remove cpu label from gpu runners

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the CI label Oct 25, 2024
Copy link
Contributor

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@ko3n1g ko3n1g force-pushed the ko3n1g/ci/cpu-only-runner branch from 06267af to 6fb40cb Compare October 25, 2024 15:31
ko3n1g and others added 4 commits October 25, 2024 21:50
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
…n failure

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/cpu-only-runner branch from 6fb40cb to 3907a95 Compare October 25, 2024 19:50
@github-actions github-actions bot added core Changes to NeMo Core ASR labels Oct 25, 2024
@ko3n1g ko3n1g added Run CICD and removed core Changes to NeMo Core ASR Run CICD labels Oct 25, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Oct 25, 2024
@github-actions github-actions bot added core Changes to NeMo Core ASR labels Oct 25, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Oct 25, 2024
@ko3n1g ko3n1g marked this pull request as ready for review October 25, 2024 20:15
@ko3n1g ko3n1g requested a review from pablo-garay as a code owner October 25, 2024 20:15
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@pablo-garay pablo-garay enabled auto-merge (squash) October 25, 2024 20:31
Copy link
Contributor

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@pablo-garay pablo-garay merged commit 90d82dc into main Oct 25, 2024
155 of 157 checks passed
@pablo-garay pablo-garay deleted the ko3n1g/ci/cpu-only-runner branch October 25, 2024 22:22
@artbataev artbataev mentioned this pull request Oct 26, 2024
8 tasks
titu1994 pushed a commit that referenced this pull request Oct 28, 2024
* ci: Switch to CPU only runner

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* runner

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* Raise EnvironmentError when CUDA is unavailable to prevent cuda-python failure

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

* Fix error message

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

* update

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* fix

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* finalize

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

---------

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
Co-authored-by: Vladimir Bataev <vbataev@nvidia.com>
ko3n1g added a commit that referenced this pull request Oct 29, 2024
* ci: Switch to CPU only runner

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* runner

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* Raise EnvironmentError when CUDA is unavailable to prevent cuda-python failure

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

* Fix error message

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

* update

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* fix

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* finalize

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

---------

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
Co-authored-by: Vladimir Bataev <vbataev@nvidia.com>
ko3n1g added a commit that referenced this pull request Oct 29, 2024
* ci: Switch to CPU only runner



* runner



* Raise EnvironmentError when CUDA is unavailable to prevent cuda-python failure



* Fix error message



* update



* fix



* finalize



---------

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
Co-authored-by: Vladimir Bataev <vbataev@nvidia.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* ci: Switch to CPU only runner

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* runner

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* Raise EnvironmentError when CUDA is unavailable to prevent cuda-python failure

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

* Fix error message

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

* update

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* fix

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* finalize

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

---------

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
Co-authored-by: Vladimir Bataev <vbataev@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
HuiyingLi pushed a commit to HuiyingLi/NeMo that referenced this pull request Nov 15, 2024
* ci: Switch to CPU only runner

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* runner

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* Raise EnvironmentError when CUDA is unavailable to prevent cuda-python failure

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

* Fix error message

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>

* update

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* fix

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* finalize

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

---------

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
Co-authored-by: Vladimir Bataev <vbataev@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASR CI core Changes to NeMo Core Run CICD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants