Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Canary adapters tutorial #11184

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

pzelasko
Copy link
Collaborator

@pzelasko pzelasko commented Nov 6, 2024

What does this PR do ?

Update prompt format fn usage in Multi-task ASR adapter tutorial

Collection: ASR

Changelog

  • Update prompt format fn usage in Multi-task ASR adapter tutorial

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
@pzelasko pzelasko added the r2.0.0 label Nov 6, 2024
@github-actions github-actions bot added ASR and removed r2.0.0 labels Nov 6, 2024
@pzelasko
Copy link
Collaborator Author

pzelasko commented Nov 6, 2024

I don't know why the diff is so big - I did the following:

  • removed the inference argument in prompt format fn / data module
  • updated the custom dataset class to return a dataclass as minibatch, same as the default prompted dataset
  • re-ran the whole notebook.

Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Copy link
Collaborator

@nithinraok nithinraok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@nithinraok nithinraok merged commit 5402076 into main Nov 6, 2024
14 checks passed
@nithinraok nithinraok deleted the fix-canary-adapters-tutorial branch November 6, 2024 14:35
Copy link
Contributor

github-actions bot commented Nov 6, 2024

[🤖]: Hi @pzelasko 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

lilyw97 pushed a commit to lilyw97/NeMo that referenced this pull request Nov 13, 2024
* Fixes for Canary adapters tutorial

Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>

* clear notebook output cells

Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>

---------

Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
HuiyingLi pushed a commit to HuiyingLi/NeMo that referenced this pull request Nov 15, 2024
* Fixes for Canary adapters tutorial

Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>

* clear notebook output cells

Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>

---------

Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
yashaswikarnati pushed a commit that referenced this pull request Nov 21, 2024
* Fixes for Canary adapters tutorial

Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>

* clear notebook output cells

Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>

---------

Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants