Pre-generate cu_seqlens argmin and max_seqlen to remove host-to-device sync #8108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins |
erhoo82
force-pushed
the
slym/no_sync_fix
branch
from
cb68ea6 to
b44a596
Compare
|
jenkins |
|
jenkins |
|
@ericharper |
|
Just waiting on internal CI tests. They look good so far. We'll most likely merge first thing tomorrow. |
|
jenkins |
erhoo82
force-pushed
the
slym/no_sync_fix
branch
from
bd87cb1 to
bec9217
Compare
|
jenkins |
…e data copies Signed-off-by: Sangkug Lym <slym@nvidia.com> [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
erhoo82
force-pushed
the
slym/no_sync_fix
branch
from
bec9217 to
1c09d92
Compare
|
jenkins |
|
jenkins |
|
jenkins |
|
jenkins |
ericharper
approved these changes
Jan 18, 2024
minitu
pushed a commit
to minitu/NeMo
that referenced
this pull request
Jan 19, 2024
…e data copies (NVIDIA#8108) Signed-off-by: Sangkug Lym <slym@nvidia.com> [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: Eric Harper <complex451@gmail.com>
akoumpa
pushed a commit
to akoumpa/NeMo
that referenced
this pull request
Jan 20, 2024
…e data copies (NVIDIA#8108) Signed-off-by: Sangkug Lym <slym@nvidia.com> [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: Eric Harper <complex451@gmail.com>
stevehuang52
pushed a commit
that referenced
this pull request
Jan 31, 2024
…e data copies (#8108) Signed-off-by: Sangkug Lym <slym@nvidia.com> [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: Eric Harper <complex451@gmail.com> Signed-off-by: stevehuang52 <heh@nvidia.com>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
…e data copies (NVIDIA#8108) Signed-off-by: Sangkug Lym <slym@nvidia.com> [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: Eric Harper <complex451@gmail.com> Signed-off-by: Sasha Meister <ameister@nvidia.com>
pablo-garay
pushed a commit
that referenced
this pull request
Mar 19, 2024
…e data copies (#8108) Signed-off-by: Sangkug Lym <slym@nvidia.com> [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: Eric Harper <complex451@gmail.com> Signed-off-by: Pablo Garay <pagaray@nvidia.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
…e data copies (NVIDIA#8108) Signed-off-by: Sangkug Lym <slym@nvidia.com> [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: Eric Harper <complex451@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e data copies
What does this PR do ?
At SFT, pre-generate
cu_seqlens_argminandmax_seqlento skip CPU-side computation on the main process.This removes host-to-device sync, which is performance-critical when each kernel execution is short.
Changelog
Usage
# Add a code snippet demonstrating how to use thisJenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkinson the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information