Add include_text parameter to SFT dataloaders #8198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Igor Gitman <igitman@nvidia.com>
8 tasks
|
jenkins |
cuichenx
requested changes
Jan 18, 2024
| @@ -58,6 +58,7 @@ def __init__( | |||
| truncation_method: str = 'right', | |||
| special_tokens: Optional[Mapping[str, str]] = None, # special tokens, a dictory of {token_type: token} | |||
| is_test: bool = False, | |||
| include_text: bool = False, | |||
There was a problem hiding this comment.
can you rename this to "output_original_text" or something to make more clear
Signed-off-by: Igor Gitman <igitman@nvidia.com>
|
jenkins |
PannuMuthu
pushed a commit
to PannuMuthu/NeMo
that referenced
this pull request
Jan 26, 2024
* Add include_text parameter to SFT dataloaders Signed-off-by: Igor Gitman <igitman@nvidia.com> * Rename include_text -> output_original_text Signed-off-by: Igor Gitman <igitman@nvidia.com> --------- Signed-off-by: Igor Gitman <igitman@nvidia.com> Signed-off-by: Pratyush Muthukumar <pmuthukumar@nvidia.com>
PannuMuthu
pushed a commit
to PannuMuthu/NeMo
that referenced
this pull request
Jan 29, 2024
* Add include_text parameter to SFT dataloaders Signed-off-by: Igor Gitman <igitman@nvidia.com> * Rename include_text -> output_original_text Signed-off-by: Igor Gitman <igitman@nvidia.com> --------- Signed-off-by: Igor Gitman <igitman@nvidia.com> Signed-off-by: Pratyush Muthukumar <pmuthukumar@nvidia.com>
PannuMuthu
pushed a commit
to PannuMuthu/NeMo
that referenced
this pull request
Jan 29, 2024
This reverts commit 2e61ecf.
odelalleau
pushed a commit
to odelalleau/NeMo
that referenced
this pull request
Jan 31, 2024
* Add include_text parameter to SFT dataloaders Signed-off-by: Igor Gitman <igitman@nvidia.com> * Rename include_text -> output_original_text Signed-off-by: Igor Gitman <igitman@nvidia.com> --------- Signed-off-by: Igor Gitman <igitman@nvidia.com>
stevehuang52
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Add include_text parameter to SFT dataloaders Signed-off-by: Igor Gitman <igitman@nvidia.com> * Rename include_text -> output_original_text Signed-off-by: Igor Gitman <igitman@nvidia.com> --------- Signed-off-by: Igor Gitman <igitman@nvidia.com> Signed-off-by: stevehuang52 <heh@nvidia.com>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
* Add include_text parameter to SFT dataloaders Signed-off-by: Igor Gitman <igitman@nvidia.com> * Rename include_text -> output_original_text Signed-off-by: Igor Gitman <igitman@nvidia.com> --------- Signed-off-by: Igor Gitman <igitman@nvidia.com> Signed-off-by: Sasha Meister <ameister@nvidia.com>
pablo-garay
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Add include_text parameter to SFT dataloaders Signed-off-by: Igor Gitman <igitman@nvidia.com> * Rename include_text -> output_original_text Signed-off-by: Igor Gitman <igitman@nvidia.com> --------- Signed-off-by: Igor Gitman <igitman@nvidia.com> Signed-off-by: Pablo Garay <pagaray@nvidia.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* Add include_text parameter to SFT dataloaders Signed-off-by: Igor Gitman <igitman@nvidia.com> * Rename include_text -> output_original_text Signed-off-by: Igor Gitman <igitman@nvidia.com> --------- Signed-off-by: Igor Gitman <igitman@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adding a new parameter to include original text in the dictionary returned from a dataloader. This is needed for a cleaner support of metrics in NeMo-Aligner.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisJenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkinson the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information