Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix operator precedence #9403

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix operator precedence #9403

merged 1 commit into from
Jun 24, 2024

Conversation

akoumpa
Copy link
Member

@akoumpa akoumpa commented Jun 6, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@akoumpa akoumpa force-pushed the akoumparouli/nemo_ux_changes branch from 777cd45 to 00168d6 Compare June 6, 2024 16:33
@akoumpa akoumpa marked this pull request as ready for review June 6, 2024 16:33
@akoumpa akoumpa self-assigned this Jun 6, 2024
@akoumpa akoumpa requested a review from marcromeyn June 6, 2024 16:34
@github-actions github-actions bot removed the NLP label Jun 6, 2024
Copy link
Contributor

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Jun 21, 2024
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa akoumpa force-pushed the akoumparouli/nemo_ux_changes branch from ba20266 to 346d103 Compare June 24, 2024 13:25
@marcromeyn marcromeyn merged commit ddcc11b into main Jun 24, 2024
112 checks passed
@marcromeyn marcromeyn deleted the akoumparouli/nemo_ux_changes branch June 24, 2024 14:00
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
ashors1 pushed a commit that referenced this pull request Jul 5, 2024
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
BuyuanCui pushed a commit to BuyuanCui/NeMo that referenced this pull request Jul 12, 2024
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
BuyuanCui pushed a commit to BuyuanCui/NeMo that referenced this pull request Jul 12, 2024
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
@ko3n1g ko3n1g mentioned this pull request Jul 18, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants