Skip to content

Commit c3948c4

Browse files
wmaxeymisccobernhardmgruber
authored
Replace pipes.quote with shlex.quote in lit config (#3547)
* Replace pipes.quote with shlex.quote * Drop TBB run on windows to unblock CI * Update ci/matrix.yaml Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com> Co-authored-by: Bernhard Manfred Gruber <bernhardmgruber@gmail.com>
1 parent cdd94ad commit c3948c4

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

ci/matrix.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,9 @@ workflows:
1919
- {jobs: ['build'], std: 'max', cxx: ['msvc2019']}
2020
- {jobs: ['build'], std: 'all', cxx: ['gcc', 'clang', 'msvc']}
2121
# Current CTK testing:
22-
- {jobs: ['test'], project: ['libcudacxx', 'thrust'], std: 'max', cxx: ['gcc']}
23-
- {jobs: ['test'], project: ['libcudacxx', 'thrust'], std: 'max', cxx: ['clang', 'msvc']}
22+
- {jobs: ['test'], project: ['libcudacxx', 'thrust'], std: 'max', cxx: ['gcc', 'clang']}
23+
# Disabled until we figure out the issue with the TBB dll
24+
#- {jobs: ['test'], project: ['libcudacxx', 'thrust'], std: 'max', cxx: ['msvc']}
2425
# Split up cub tests:
2526
- {jobs: ['test_nolid', 'test_lid0'], project: ['cub'], std: 'max', cxx: ['gcc']}
2627
- {jobs: ['test_lid1', 'test_lid2'], project: ['cub'], std: 'max', cxx: ['gcc']}

libcudacxx/test/utils/libcudacxx/test/config.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
import ctypes
1010
import os
11-
import pipes
1211
import platform
1312
import re
1413
import shlex
@@ -1512,14 +1511,14 @@ def configure_modules(self):
15121511

15131512
def configure_substitutions(self):
15141513
sub = self.config.substitutions
1515-
cxx_path = pipes.quote(self.cxx.path)
1514+
cxx_path = shlex.quote(self.cxx.path)
15161515
# Configure compiler substitutions
15171516
sub.append(("%cxx", cxx_path))
15181517
sub.append(("%libcxx_src_root", self.libcudacxx_src_root))
15191518
# Configure flags substitutions
1520-
flags_str = " ".join([pipes.quote(f) for f in self.cxx.flags])
1521-
compile_flags_str = " ".join([pipes.quote(f) for f in self.cxx.compile_flags])
1522-
link_flags_str = " ".join([pipes.quote(f) for f in self.cxx.link_flags])
1519+
flags_str = " ".join([shlex.quote(f) for f in self.cxx.flags])
1520+
compile_flags_str = " ".join([shlex.quote(f) for f in self.cxx.compile_flags])
1521+
link_flags_str = " ".join([shlex.quote(f) for f in self.cxx.link_flags])
15231522
all_flags = "%s %s %s" % (flags_str, compile_flags_str, link_flags_str)
15241523
sub.append(("%flags", flags_str))
15251524
sub.append(("%compile_flags", compile_flags_str))
@@ -1548,7 +1547,7 @@ def configure_substitutions(self):
15481547
sub.append(("%run", "%t.exe"))
15491548
# Configure not program substitutions
15501549
not_py = os.path.join(self.libcudacxx_src_root, "test", "utils", "not.py")
1551-
not_str = "%s %s " % (pipes.quote(sys.executable), pipes.quote(not_py))
1550+
not_str = "%s %s " % (shlex.quote(sys.executable), shlex.quote(not_py))
15521551
sub.append(("not ", not_str))
15531552
if self.get_lit_conf("libcudacxx_gdb"):
15541553
sub.append(("%libcxx_gdb", self.get_lit_conf("libcudacxx_gdb")))

0 commit comments

Comments
 (0)