[nvmdev] fix bug in construction of parent PCI device #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When constructing NvidiaPCIDevice objects for each 'parent' device in the '/sys/class/mdev_bus' directory, use the default PCI devices root '/sys/bus/pci/devices'. All devices in '/sys/class/mdev_bus' will have a corresponding directory at '/sys/bus/pci/devices'. Starting with NVIDIA@bf3f431 the construction of the NvidiaPCIDevice object will fail when attempting to detect the physfn. When SRIOV is used, all the VFs will show up under '/sys/class/mdev_bus', but the physfn will only show up under '/sys/bus/pci/devices'. Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
|
The commit you linked is a broken link. What was the change that broke things? |
|
@PiotrProkop can you take a look at this |
|
To provide more context, a call to
|
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
cdesiniotis
force-pushed
the
fix-nvmdev-new-parent-device
branch
from
7374add
to
7c3222d
Compare
tariq1890
approved these changes
Jul 15, 2024
|
Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When constructing NvidiaPCIDevice objects for each 'parent' device in the '/sys/class/mdev_bus' directory, use the default PCI devices root '/sys/bus/pci/devices'. All devices in '/sys/class/mdev_bus' will have a corresponding directory at '/sys/bus/pci/devices'.
Starting with bf3f431 the construction of the NvidiaPCIDevice object will fail when attempting to detect the physfn. When SRIOV is used, all the VFs will show up under '/sys/class/mdev_bus', but the physfn will only show up under '/sys/bus/pci/devices'.