Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove address from map when closing out search #1167

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

bmarchena
Copy link
Contributor

@bmarchena bmarchena commented Apr 11, 2024

Closes #1152.

Also updates start:local-api script

@bmarchena bmarchena requested a review from a team as a code owner April 11, 2024 18:14
Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for labs-factfinder ready!

Name Link
🔨 Latest commit b6fdaba
🔍 Latest deploy log https://app.netlify.com/sites/labs-factfinder/deploys/661e6f654cc40b000816d1e7
😎 Deploy Preview https://deploy-preview-1167--labs-factfinder.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@TylerMatteo TylerMatteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just undo the package.json change and then lgtm.

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@TylerMatteo TylerMatteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just undo the package.json change and then lgtm.

@bmarchena bmarchena force-pushed the 1152/address-clear-after-close-search branch from 602fe9f to b6fdaba Compare April 16, 2024 12:30
@bmarchena bmarchena merged commit bbe4165 into develop Apr 19, 2024
5 checks passed
@bmarchena bmarchena deleted the 1152/address-clear-after-close-search branch April 19, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The pinned address/ geography does not go away after the search is x'ed out
2 participants