Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocompletion broke completion for paths (file, destination, database) #38

Closed
Nagasaki45 opened this issue Jun 19, 2019 · 7 comments
Closed
Assignees

Comments

@Nagasaki45
Copy link
Owner

No description provided.

@Nagasaki45 Nagasaki45 changed the title Autocompletion brok autocomplete for paths (file, destination, database) Autocompletion broke completion for paths (file, destination, database) Jun 19, 2019
@Nagasaki45
Copy link
Owner Author

There's no much to do here on bibo's side. The topic is discussed on click's issues (pallets/click#780 & pallets/click#782). Just wait for a patch upstream...

@Nagasaki45
Copy link
Owner Author

It's a bit of a bummer that click still doesn't support auto-completion for paths. I wonder if we should wait with alpha release until this is implemented.

@Kappers
Copy link
Contributor

Kappers commented Mar 25, 2020

I agree that this is a pain, and that bibo isn't the place to patch this up - that being said, if this blocked alpha (which I think is reasonable), that'd be a shame.

I suppose it'd be easy enough to add an autocomplete function to the add click.option that just transformed current input into a glob and prompted matches. Maybe, a plugin could be added as dependency which handles this until click is sorted, e.g. somehow decorating the existing add command to provide a DIY auto-complete layer, creating a bespoke addfile (not ideal)....

@Nagasaki45
Copy link
Owner Author

I'm up for implementing a temporary solution. Don't think it should be a plugin. The goal is to give users a pleasant interface without plugins and use plugins for extras. Do you want to give it a shot? I can also do this, up to you :-)

@Kappers
Copy link
Contributor

Kappers commented Mar 25, 2020

I'll give it a shot! 👍

@Nagasaki45
Copy link
Owner Author

Cool!!!

@Nagasaki45
Copy link
Owner Author

Fixed in 90aa658 and 851929b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants