-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 Bible Verse Finder - HTML -> Next.js #2
Comments
Hey! Using anyting like Nextjs or any other framework will not impact our ML model in any way , we can freely use any framework in the frontend |
You are on it!!! I was just setting this up for anyone who wanted to join. |
Thanks for letting me know @Namit2111 , if we wanted too, would anything change? I just don't want to interfere with the calls within the HTML file |
No! Nothing will change |
Alright let me change the issue! |
something cool - https://magicui.design/docs/components/rainbow-button |
|
If you have any questions about this issue please comment them here! |
Hey @JustinhSE as mentioned on Discord there are a few steps to migrate from html to next.js so can you break this issue in parts (divide and conquer)? so that it becomes easy to keep track of the progress and resolve one issue at a time. |
This is looking interesting. In addition to @rajatkriplani's suggestion, @JustinhSE, do you have a design in mind for |
@d-beloved honestly, migration is most important at this point. Although a good looking UX at the end of this issue would be amazing, I am more concerned about the backend aspect of this right now. You can reference our deployed version in our The most important thing is just integrating the 2 so that input and output work accordingly |
So home for example could literally be text of home. But the Bible verse similarity tab in next.js would need the functionality our current one does |
@rajatkriplani yes but to break this issue down into smaller ones, I would need to know the tasks you would like to do so I can plan accordingly |
Below are the step to migrate, and please let me know if I'm missing anything: Backend
Frontend
Deployment
I can start with updating page.tsx and build it using:
|
These steps seems solid to me @rajatkriplani, I am available for the
frontend aspect of things (converting index.html to Next.js) if it'll be an
handful for you. cc: @JustinfhSE
…On Sun, Oct 6, 2024, 07:37 rajatkriplani ***@***.***> wrote:
Hey @JustinhSE <https://github.com/JustinhSE> as mentioned on Discord
there are a few steps to migrate from html to next.js so can you break this
issue in parts (divide and conquer)? so that it becomes easy to keep track
of the progress and resolve one issue at a time.
@rajatkriplani <https://github.com/rajatkriplani> yes but to break this
issue down into smaller ones, I would need to know the tasks you would like
to do so I can plan accordingly
Below are the step to migrate, and please let me know if I'm missing
anything:
Backend
- Keep flask backend or switch to next.js API?
- Changeapp.py to return JSON
Frontend
- Convert index.html to Next.js
- similarity.txt use fetch to call Flask or Next.js API
- Update page.tsx
Deployment
- Well this depends upon Flask or Next.js
I can start with updating page.tsx and build it using:
- utils.ts (cn function)
- globals.css which contains Tailwind's base
- layout.tsx for structure and global elements.
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGKJ244SQJQWZS2CIQMBP2TZ2DLBVAVCNFSM6AAAAABOZFQWV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGMYTKNRZHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@rajatkriplani the steps look great! @d-beloved you can also work on this issue, but you both will have to coordinate tasks. |
Pinging @Namit2111 for the deployment steps however to make sure these changes do not cause side effects |
okay, I'll start with page.tsx and will get in touch with @d-beloved to keep him updated. |
Hi! @rajatkriplani For frontend we want similar ui that is copy the design of Index.html in nextjs , in nextjs use the flask app for completion of the app. Your steps seems to align with what we want , so go ahead and let us know for any issue. |
I'm updating |
Can you provide a timeline @rajatkriplani and @d-beloved |
anything between 1 to 2 hours. And @d-beloved please drop you discord. |
@Namit2111 I created a PR to update |
Hey @rajatkriplani, I am not on my system at the moment. I'm at Church. You
can pick it up if you're able to work on it now. I'll check back later
today to know the status.
…On Sun, Oct 6, 2024, 09:39 rajatkriplani ***@***.***> wrote:
@Namit2111 <https://github.com/Namit2111> I created a PR to update
page.tsx but I'm not aware if @d-beloved <https://github.com/d-beloved>
is working on index.html as I was unable to make any contact.
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGKJ24YXFKDFPCHGRCILQCTZ2DZLTAVCNFSM6AAAAABOZFQWV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGM2TAMRWGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@rajatkriplani I have messaged you on the project thread on Discord |
Overview
Our current framework is good, but we want to take this to the next level. Using something like Next.js will help us route and scale this project easier. We want to have a new UX and upgraded visual, multiple pages (home page and bible verse similarity), and it should be written in TypeScript (preferred) or JavaScript.
Tasks
index.html
file so that we can upgrade our tech stack.The text was updated successfully, but these errors were encountered: